diff --git a/.changeset/twelve-badgers-beg.md b/.changeset/twelve-badgers-beg.md new file mode 100644 index 0000000000..c7f6028bca --- /dev/null +++ b/.changeset/twelve-badgers-beg.md @@ -0,0 +1,5 @@ +--- +"@primer/view-components": patch +--- + +Upgrade Primitives and PCSS, rename tokens to pre-v8 release diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/beta/auto_complete_item/default.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/beta/auto_complete_item/default.png index 5ede11aa65..9716205221 100644 Binary files a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/beta/auto_complete_item/default.png and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/beta/auto_complete_item/default.png differ diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/beta/auto_complete_item/focused.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/beta/auto_complete_item/focused.png index f4bfd2c534..59a7ef0d28 100644 Binary files a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/beta/auto_complete_item/focused.png and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/beta/auto_complete_item/focused.png differ diff --git a/app/components/primer/alpha/action_list.pcss b/app/components/primer/alpha/action_list.pcss index 03f7d6e723..89b79b6641 100644 --- a/app/components/primer/alpha/action_list.pcss +++ b/app/components/primer/alpha/action_list.pcss @@ -1,5 +1,5 @@ :root { - --primer-actionListContent-paddingBlock: var(--primer-control-medium-paddingBlock, 6px); + --actionListContent-paddingBlock: var(--control-medium-paddingBlock, 6px); } /* ActionList */ @@ -18,7 +18,7 @@ .ActionListWrap--divided { & .ActionListItem-label::before { position: absolute; - top: calc(-1 * var(--primer-actionListContent-paddingBlock)); + top: calc(-1 * var(--actionListContent-paddingBlock)); display: block; width: 100%; height: 1px; @@ -30,10 +30,10 @@ & .ActionListItem-descriptionWrap--inline { &::before { position: absolute; - top: calc(-1 * var(--primer-actionListContent-paddingBlock)); + top: calc(-1 * var(--actionListContent-paddingBlock)); display: block; width: 100%; - height: var(--primer-borderWidth-thin, 1px); + height: var(--borderWidth-thin, 1px); content: ''; background: var(--color-action-list-item-inline-divider); } @@ -71,7 +71,7 @@ position: relative; list-style: none; background-color: transparent; - border-radius: var(--primer-borderRadius-medium, 6px); + border-radius: var(--borderRadius-medium, 6px); /* state */ @@ -129,9 +129,9 @@ &:not(.ActionListItem--navActive, :focus-visible) { /* Support for "Windows high contrast mode" */ - outline: solid var(--primer-borderWidth-thin, 1px) transparent; - outline-offset: calc(-1 * var(--primer-borderWidth-thin, 1px)); - box-shadow: var(--primer-borderInset-thin, 1px) var(--color-action-list-item-default-active-border); + outline: solid var(--borderWidth-thin, 1px) transparent; + outline-offset: calc(-1 * var(--borderWidth-thin, 1px)); + box-shadow: var(--borderInset-thin, 1px) var(--color-action-list-item-default-active-border); } } } @@ -141,9 +141,9 @@ &:not(.ActionListItem--navActive) { /* Support for "Windows high contrast mode" https:sarahmhigley.com/writing/whcm-quick-tips/ */ - outline: solid var(--primer-borderWidth-thin, 1px) transparent; - outline-offset: calc(-1 * var(--primer-borderWidth-thin, 1px)); - box-shadow: var(--primer-borderInset-thin, 1px) var(--color-action-list-item-default-active-border); + outline: solid var(--borderWidth-thin, 1px) transparent; + outline-offset: calc(-1 * var(--borderWidth-thin, 1px)); + box-shadow: var(--borderInset-thin, 1px) var(--color-action-list-item-default-active-border); } & .ActionListItem-label::before, @@ -189,7 +189,7 @@ & .ActionListItem-multiSelectIconRect { fill: var(--color-accent-fg); stroke: var(--color-accent-fg); - stroke-width: var(--primer-borderWidth-thin, 1px); + stroke-width: var(--borderWidth-thin, 1px); } & .ActionListItem-multiSelectCheckmark { @@ -232,13 +232,13 @@ & .ActionListItem-multiSelectIconRect { fill: var(--color-canvas-default); stroke: var(--color-border-default); - stroke-width: var(--primer-borderWidth-thin, 1px); + stroke-width: var(--borderWidth-thin, 1px); } } & .ActionListItem-multiSelectIconRect { fill: var(--color-canvas-default); - border: var(--primer-borderWidth-thin, 1px) solid var(--color-border-default); + border: var(--borderWidth-thin, 1px) solid var(--color-border-default); } } @@ -360,14 +360,14 @@ position: relative; display: grid; width: 100%; - padding-block: var(--primer-actionListContent-paddingBlock); - padding-inline: var(--primer-control-medium-paddingInline-condensed, 8px); + padding-block: var(--actionListContent-paddingBlock); + padding-inline: var(--control-medium-paddingInline-condensed, 8px); color: var(--color-fg-default); text-align: left; user-select: none; background-color: transparent; border: none; - border-radius: var(--primer-borderRadius-medium, 6px); + border-radius: var(--borderRadius-medium, 6px); transition: background 33.333ms linear; touch-action: manipulation; -webkit-tap-highlight-color: transparent; @@ -378,7 +378,7 @@ /* column-gap persists with empty grid-areas, margin applies only when children exist */ & > :not(:last-child) { - margin-right: var(--primer-control-medium-gap, 8px); + margin-right: var(--control-medium-gap, 8px); } /* state */ @@ -501,16 +501,16 @@ /* sizes */ &.ActionListContent--sizeLarge { - --primer-actionListContent-paddingBlock: var(--primer-control-large-paddingBlock, calc((2.5rem - 1.25rem) / 2)); + --actionListContent-paddingBlock: var(--control-large-paddingBlock, calc((2.5rem - 1.25rem) / 2)); } &.ActionListContent--sizeXLarge { - --primer-actionListContent-paddingBlock: var(--primer-control-xlarge-paddingBlock, calc((3rem - 1.25rem) / 2)); + --actionListContent-paddingBlock: var(--control-xlarge-paddingBlock, calc((3rem - 1.25rem) / 2)); } /* On pointer:coarse (mobile), all list items are large */ @media (pointer: coarse) { - --primer-actionListContent-paddingBlock: var(--primer-control-large-paddingBlock, calc((2.5rem - 1.25rem) / 2)); + --actionListContent-paddingBlock: var(--control-large-paddingBlock, calc((2.5rem - 1.25rem) / 2)); } &.ActionListContent--blockDescription { @@ -562,9 +562,9 @@ /* description */ .ActionListItem-description { - font-size: var(--primer-text-body-size-small, 12px); + font-size: var(--text-body-size-small, 12px); font-weight: var(--base-text-weight-normal, 400); - line-height: var(--primer-text-body-lineHeight-small, calc(20 / 12)); + line-height: var(--text-body-lineHeight-small, calc(20 / 12)); color: var(--color-fg-muted); } @@ -573,7 +573,7 @@ .ActionListItem-visual, .ActionListItem-action { display: flex; - min-height: var(--primer-control-medium-lineBoxHeight, 20px); + min-height: var(--control-medium-lineBoxHeight, 20px); color: var(--color-fg-muted); pointer-events: none; fill: var(--color-fg-muted); @@ -583,9 +583,9 @@ /* text */ .ActionListItem-label { position: relative; - font-size: var(--primer-text-body-size-medium, 14px); + font-size: var(--text-body-size-medium, 14px); font-weight: var(--base-text-weight-normal, 400); - line-height: var(--primer-text-body-lineHeight-medium, calc(20 / 14)); + line-height: var(--text-body-lineHeight-medium, calc(20 / 14)); color: var(--color-fg-default); grid-area: label; } @@ -600,8 +600,8 @@ target ActionListItem--subItem for padding-left to maintain :active :after state */ .ActionListItem--subItem > .ActionListContent > .ActionListItem-label { - font-size: var(--primer-text-body-size-small, 12px); - line-height: var(--primer-text-body-lineHeight-small, calc(20 / 12)); + font-size: var(--text-body-size-small, 12px); + line-height: var(--text-body-lineHeight-small, calc(20 / 12)); } /* trailing action icon button */ @@ -638,10 +638,10 @@ /* with children */ &:not(:empty) { display: flex; - padding-inline: var(--primer-actionListContent-paddingBlock); + padding-inline: var(--actionListContent-paddingBlock); padding-block: var(--base-size-8, 8px); - font-size: var(--primer-text-body-size-small, 12px); - line-height: var(--primer-text-body-lineHeight-small, calc(20 / 12)); + font-size: var(--text-body-size-small, 12px); + line-height: var(--text-body-lineHeight-small, calc(20 / 12)); font-weight: var(--base-text-weight-semibold, 600); color: var(--color-fg-muted); flex-direction: column; @@ -650,9 +650,9 @@ /* no children */ &:empty { display: block; - height: var(--primer-borderWidth-thin, 1px); + height: var(--borderWidth-thin, 1px); padding: 0; - margin-block-start: calc(var(--base-size-8, 8px) - var(--primer-borderWidth-thin, 1px)); + margin-block-start: calc(var(--base-size-8, 8px) - var(--borderWidth-thin, 1px)); margin-block-end: var(--base-size-8, 8px); margin-inline: calc(-1 * var(--base-size-8, 8px)); list-style: none; @@ -661,19 +661,19 @@ } & .ActionList-sectionDivider-title { - font-size: var(--primer-text-body-size-small, 12px); + font-size: var(--text-body-size-small, 12px); font-weight: var(--base-text-weight-semibold, 600); color: var(--color-fg-muted); } } .ActionList-sectionDivider--filled { - margin-block-start: calc(var(--base-size-8, 8px) - var(--primer-borderWidth-thin, 1px)); + margin-block-start: calc(var(--base-size-8, 8px) - var(--borderWidth-thin, 1px)); margin-block-end: var(--base-size-8, 8px); margin-inline: calc(-1 * var(--base-size-8, 8px)); background: var(--color-canvas-subtle); - border-top: solid var(--primer-borderWidth-thin, 1px) var(--color-action-list-item-inline-divider); - border-bottom: solid var(--primer-borderWidth-thin, 1px) var(--color-action-list-item-inline-divider); + border-top: solid var(--borderWidth-thin, 1px) var(--color-action-list-item-inline-divider); + border-bottom: solid var(--borderWidth-thin, 1px) var(--color-action-list-item-inline-divider); /* if no children, treat as divider */ &:empty { diff --git a/app/components/primer/alpha/auto_complete.pcss b/app/components/primer/alpha/auto_complete.pcss index 6ea46502d3..52808ab45b 100644 --- a/app/components/primer/alpha/auto_complete.pcss +++ b/app/components/primer/alpha/auto_complete.pcss @@ -69,8 +69,8 @@ font-size: 13px; list-style: none; background: var(--color-canvas-overlay); - border: var(--primer-borderWidth-thin, 1px) solid var(--color-border-default); - border-radius: var(--primer-borderRadius-medium, 6px); + border: var(--borderWidth-thin, 1px) solid var(--color-border-default); + border-radius: var(--borderRadius-medium, 6px); box-shadow: var(--color-shadow-medium); } diff --git a/app/components/primer/alpha/banner.pcss b/app/components/primer/alpha/banner.pcss index f6014ed751..852ddca425 100644 --- a/app/components/primer/alpha/banner.pcss +++ b/app/components/primer/alpha/banner.pcss @@ -6,11 +6,11 @@ padding: var(--base-size-8, 8px); color: var(--color-fg-default); background-image: linear-gradient(var(--color-accent-subtle), var(--color-accent-subtle)); - border: var(--primer-borderWidth-thin, max(1px, 0.0625rem)) solid var(--color-accent-muted); - border-radius: var(--primer-borderRadius-medium, 6px); + border: var(--borderWidth-thin, max(1px, 0.0625rem)) solid var(--color-accent-muted); + border-radius: var(--borderRadius-medium, 6px); grid-auto-flow: column; grid-template-areas: 'visual message actions close'; - grid-template-columns: min-content 1fr minmax(0,auto) min-content; + grid-template-columns: min-content 1fr minmax(0, auto) min-content; grid-template-rows: min-content; /* `sm` breakpoint variantion */ @@ -22,7 +22,7 @@ grid-template-rows: min-content min-content; & .Banner-actions { - margin: var(--base-size-8, 8px) 0 0 var(--base-size-8, 8px); + margin: var(--base-size-8, 8px) 0 0 var(--base-size-8, 8px); } } @@ -69,7 +69,7 @@ /* is this used anywhere? could not find any use, but unsure */ & .Banner-close { grid-area: close; - margin-left: var(--primer-controlStack-medium-gap-condensed, 8px); + margin-left: var(--controlStack-medium-gap-condensed, 8px); } & .Banner-visual .octicon { @@ -109,7 +109,7 @@ /* Full-width */ &.Banner--full { - margin-top: calc(var(--primer-borderWidth-thin, max(1px, 0.0625rem)) * -1); + margin-top: calc(var(--borderWidth-thin, max(1px, 0.0625rem)) * -1); border-right: 0; border-left: 0; border-radius: 0; @@ -117,7 +117,7 @@ @media (max-width: 767.98px) { &.Banner--full-whenNarrow { - margin-top: calc(var(--primer-borderWidth-thin, max(1px, 0.0625rem)) * -1); + margin-top: calc(var(--borderWidth-thin, max(1px, 0.0625rem)) * -1); border-right: 0; border-left: 0; border-radius: 0; diff --git a/app/components/primer/alpha/dialog.pcss b/app/components/primer/alpha/dialog.pcss index 3265abba1f..e4d384c13f 100644 --- a/app/components/primer/alpha/dialog.pcss +++ b/app/components/primer/alpha/dialog.pcss @@ -19,7 +19,7 @@ white-space: normal; flex-direction: column; background-color: var(--color-canvas-overlay); - border-radius: var(--primer-borderRadius-large, 12px); + border-radius: var(--borderRadius-large, 12px); box-shadow: var(--color-overlay-shadow); opacity: 1; @@ -154,25 +154,25 @@ flex-direction: column; &.Overlay-header--divided { - padding-bottom: var(--primer-stack-padding-condensed, 8px); - box-shadow: inset 0 calc(var(--primer-borderWidth-thin, 1px) * -1) var(--color-border-default); + padding-bottom: var(--stack-padding-condensed, 8px); + box-shadow: inset 0 calc(var(--borderWidth-thin, 1px) * -1) var(--color-border-default); & + .Overlay-body { - padding-top: var(--primer-stack-padding-normal, 16px); + padding-top: var(--stack-padding-normal, 16px); } } &.Overlay-header--large { & .Overlay-headerContentWrap { & .Overlay-titleWrap { - gap: var(--primer-stack-gap-condensed, 8px); + gap: var(--stack-gap-condensed, 8px); & .Overlay-title { - font-size: var(--primer-text-title-size-medium, 20px); + font-size: var(--text-title-size-medium, 20px); } & .Overlay-description { - font-size: var(--primer-text-body-size-medium, 14px); + font-size: var(--text-body-size-medium, 14px); } } } @@ -181,31 +181,32 @@ & .Overlay-headerContentWrap { display: flex; align-items: flex-start; - gap: var(--primer-stack-gap-condensed, 8px); - padding: var(--primer-stack-gap-condensed, 8px) var(--primer-stack-gap-condensed, 8px) 0 var(--primer-stack-gap-condensed, 8px); + gap: var(--stack-gap-condensed, 8px); + padding: var(--stack-gap-condensed, 8px) var(--stack-gap-condensed, 8px) 0 var(--stack-gap-condensed, 8px); & .Overlay-actionWrap { display: flex; flex-direction: row; - gap: var(--primer-stack-gap-condensed, 8px); + gap: var(--stack-gap-condensed, 8px); } & .Overlay-titleWrap { display: flex; - padding: calc(var(--primer-stack-gap-condensed, 8px) * 0.75) 0 calc(var(--primer-stack-gap-condensed, 8px) * 0.75) var(--primer-stack-gap-condensed, 8px); + padding: calc(var(--stack-gap-condensed, 8px) * 0.75) 0 calc(var(--stack-gap-condensed, 8px) * 0.75) + var(--stack-gap-condensed, 8px); flex-direction: column; flex-grow: 1; - gap: var(--primer-control-small-gap, 4px); + gap: var(--control-small-gap, 4px); & .Overlay-title { margin: 0; - font-size: var(--primer-text-body-size-medium, 14px); + font-size: var(--text-body-size-medium, 14px); font-weight: var(--base-text-weight-semibold, 600); } & .Overlay-description { margin: 0; - font-size: var(--primer-text-body-size-small, 12px); + font-size: var(--text-body-size-small, 12px); font-weight: var(--base-text-weight-normal, 400); color: var(--color-fg-muted); } @@ -215,15 +216,15 @@ /* generic body content slot */ .Overlay-body { - padding: var(--primer-stack-padding-normal, 16px); + padding: var(--stack-padding-normal, 16px); padding-top: 0; overflow-y: auto; scrollbar-width: thin; - font-size: var(--primer-text-body-size-medium, 14px); + font-size: var(--text-body-size-medium, 14px); flex-grow: 1; &.Overlay-body--paddingCondensed { - padding: var(--primer-stack-padding-condensed, 8px); + padding: var(--stack-padding-condensed, 8px); padding-top: 0; } @@ -236,29 +237,29 @@ .Overlay-footer { z-index: 1; display: flex; - padding: 0 var(--primer-stack-padding-normal, 16px) var(--primer-stack-padding-normal, 16px) var(--primer-stack-padding-normal, 16px); + padding: 0 var(--stack-padding-normal, 16px) var(--stack-padding-normal, 16px) var(--stack-padding-normal, 16px); flex-direction: row; flex-shrink: 0; flex-wrap: wrap; &.Overlay-footer--divided { - padding-top: var(--primer-stack-padding-normal, 16px); - box-shadow: inset 0 var(--primer-borderWidth-thin, 1px) var(--color-border-default); + padding-top: var(--stack-padding-normal, 16px); + box-shadow: inset 0 var(--borderWidth-thin, 1px) var(--color-border-default); } &.Overlay-footer--alignStart { justify-content: flex-start; - gap: var(--primer-stack-gap-condensed, 8px); + gap: var(--stack-gap-condensed, 8px); } &.Overlay-footer--alignCenter { justify-content: center; - gap: var(--primer-stack-gap-condensed, 8px); + gap: var(--stack-gap-condensed, 8px); } &.Overlay-footer--alignEnd { justify-content: flex-end; - gap: var(--primer-stack-gap-condensed, 8px); + gap: var(--stack-gap-condensed, 8px); } } @@ -273,8 +274,8 @@ cursor: pointer; user-select: none; background-color: transparent; - border: var(--primer-borderWidth-thin, 1px) solid transparent; - border-radius: var(--primer-borderRadius-medium, 6px); + border: var(--borderWidth-thin, 1px) solid transparent; + border-radius: var(--borderRadius-medium, 6px); transition: 0.2s cubic-bezier(0.3, 0, 0.5, 1); transition-property: color, background-color, border-color; place-content: center; @@ -284,12 +285,12 @@ &:hover, &:focus { background-color: var(--color-btn-hover-bg); - border: var(--primer-borderWidth-thin, 1px) solid var(--color-btn-hover-bg); + border: var(--borderWidth-thin, 1px) solid var(--color-btn-hover-bg); } /* Override .close-button's `border: 0` that triggers a border-color transition on hover */ &.close-button { - border: var(--primer-borderWidth-thin, 1px) solid transparent; + border: var(--borderWidth-thin, 1px) solid transparent; } } @@ -342,7 +343,7 @@ & > .Overlay$(responsiveVariant) { height: 100vh; max-height: unset; - border-radius: var(--primer-borderRadius-large, 12px); + border-radius: var(--borderRadius-large, 12px); border-top-left-radius: 0; border-bottom-left-radius: 0; @@ -359,7 +360,7 @@ & > .Overlay$(responsiveVariant) { height: 100vh; max-height: unset; - border-radius: var(--primer-borderRadius-large, 12px); + border-radius: var(--borderRadius-large, 12px); border-top-right-radius: 0; border-bottom-right-radius: 0; @@ -377,7 +378,7 @@ width: 100vw; height: auto; max-height: calc(100vh - 2rem); - border-radius: var(--primer-borderRadius-large, 12px); + border-radius: var(--borderRadius-large, 12px); border-bottom-right-radius: 0; border-bottom-left-radius: 0; @@ -392,7 +393,7 @@ justify-content: center; & > .Overlay$(responsiveVariant) { - border-radius: var(--primer-borderRadius-large, 12px); + border-radius: var(--borderRadius-large, 12px); border-top-left-radius: 0; border-top-right-radius: 0; @@ -436,7 +437,7 @@ /* responsive variants */ -/* --primer-viewportRange-narrowLandscape */ +/* --viewportRange-narrowLandscape */ @media (max-width: 767px) { .Overlay-backdrop--center-whenNarrow { @mixin Overlay-backdrop--center; diff --git a/app/components/primer/alpha/dropdown.pcss b/app/components/primer/alpha/dropdown.pcss index 093a6c1616..129efa563f 100644 --- a/app/components/primer/alpha/dropdown.pcss +++ b/app/components/primer/alpha/dropdown.pcss @@ -11,7 +11,7 @@ vertical-align: middle; content: ''; border-style: solid; - border-width: var(--primer-borderWidth-thicker, 4px) var(--primer-borderWidth-thicker, 4px) 0; + border-width: var(--borderWidth-thicker, 4px) var(--borderWidth-thicker, 4px) 0; border-right-color: transparent; border-bottom-color: transparent; border-left-color: transparent; @@ -26,14 +26,14 @@ left: 0; z-index: 100; width: 160px; - padding-top: var(--primer-control-small-paddingBlock, 4px); - padding-bottom: var(--primer-control-small-paddingBlock, 4px); + padding-top: var(--control-small-paddingBlock, 4px); + padding-bottom: var(--control-small-paddingBlock, 4px); margin-top: 2px; list-style: none; background-color: var(--color-canvas-overlay); background-clip: padding-box; - border: var(--primer-borderWidth-thin, 1px) solid var(--color-border-default); - border-radius: var(--primer-borderRadius-medium, 6px); + border: var(--borderWidth-thin, 1px) solid var(--color-border-default); + border-radius: var(--borderRadius-medium, 6px); box-shadow: var(--color-shadow-large); &::before, @@ -64,7 +64,7 @@ width: auto; & .dropdown-item { - padding: var(--primer-control-small-paddingBlock, 4px) var(--primer-control-medium-paddingInline-spacious, 16px); + padding: var(--control-small-paddingBlock, 4px) var(--control-medium-paddingInline-spacious, 16px); overflow: visible; text-overflow: inherit; } @@ -73,7 +73,8 @@ /* Dropdown items (can be links or buttons) */ .dropdown-item { display: block; - padding: var(--primer-control-small-paddingBlock, 4px) var(--primer-control-medium-paddingInline-condensed, 8px) var(--primer-control-small-paddingBlock, 4px) var(--primer-control-medium-paddingInline-spacious, 16px); + padding: var(--control-small-paddingBlock, 4px) var(--control-medium-paddingInline-condensed, 8px) + var(--control-small-paddingBlock, 4px) var(--control-medium-paddingInline-spacious, 16px); overflow: hidden; color: var(--color-fg-default); text-overflow: ellipsis; @@ -115,13 +116,13 @@ .dropdown-divider { display: block; height: 0; - margin: var(--primer-stack-gap-condensed, 8px) 0; - border-top: var(--primer-borderWidth-thin, 1px) solid var(--color-border-default); + margin: var(--stack-gap-condensed, 8px) 0; + border-top: var(--borderWidth-thin, 1px) solid var(--color-border-default); } .dropdown-header { - padding: var(--primer-control-small-paddingBlock, 4px) var(--primer-control-medium-paddingInline-spacious, 16px); - font-size: var(--primer-text-body-size-small, 12px); + padding: var(--control-small-paddingBlock, 4px) var(--control-medium-paddingInline-spacious, 16px); + font-size: var(--text-body-size-small, 12px); color: var(--color-fg-muted); } diff --git a/app/components/primer/alpha/layout.pcss b/app/components/primer/alpha/layout.pcss index 33ccd6901a..e5e23f4cce 100644 --- a/app/components/primer/alpha/layout.pcss +++ b/app/components/primer/alpha/layout.pcss @@ -73,7 +73,7 @@ background: var(--color-canvas-inset); border-color: var(--color-border-default); border-style: solid; - border-width: var(--primer-borderWidth-thin, 1px) 0; + border-width: var(--borderWidth-thin, 1px) 0; } } } @@ -255,14 +255,14 @@ } & .Layout-main-centered-md { - max-width: calc(var(--primer-breakpoint-medium, 768px) + var(--Layout-sidebar-width) + var(--Layout-gutter)); + max-width: calc(var(--breakpoint-medium, 768px) + var(--Layout-sidebar-width) + var(--Layout-gutter)); } & .Layout-main-centered-lg { - max-width: calc(var(--primer-breakpoint-large, 1012px) + var(--Layout-sidebar-width) + var(--Layout-gutter)); + max-width: calc(var(--breakpoint-large, 1012px) + var(--Layout-sidebar-width) + var(--Layout-gutter)); } & .Layout-main-centered-xl { - max-width: calc(var(--primer-breakpoint-xlarge, 1280px) + var(--Layout-sidebar-width) + var(--Layout-gutter)); + max-width: calc(var(--breakpoint-xlarge, 1280px) + var(--Layout-sidebar-width) + var(--Layout-gutter)); } } diff --git a/app/components/primer/alpha/menu.pcss b/app/components/primer/alpha/menu.pcss index fcfc59b5af..22ecb2f7c0 100644 --- a/app/components/primer/alpha/menu.pcss +++ b/app/components/primer/alpha/menu.pcss @@ -3,37 +3,37 @@ /* A menu on the side of a page, defaults to left side. e.g. github.com/about */ .menu { - margin-bottom: var(--primer-stack-gap-normal, 16px); + margin-bottom: var(--stack-gap-normal, 16px); list-style: none; background-color: var(--color-canvas-default); - border: var(--primer-borderWidth-thin, 1px) solid var(--color-border-default); - border-radius: var(--primer-borderRadius-medium, 6px); + border: var(--borderWidth-thin, 1px) solid var(--color-border-default); + border-radius: var(--borderRadius-medium, 6px); } .menu-item { position: relative; display: block; - padding: var(--primer-control-medium-paddingInline-condensed, 8px) var(--primer-control-medium-paddingInline-spacious, 16px); + padding: var(--control-medium-paddingInline-condensed, 8px) var(--control-medium-paddingInline-spacious, 16px); color: var(--color-fg-default); - border-bottom: var(--primer-borderWidth-thin, 1px) solid var(--color-border-muted); + border-bottom: var(--borderWidth-thin, 1px) solid var(--color-border-muted); &:first-child { border-top: 0; - border-top-left-radius: var(--primer-borderRadius-medium, 6px); - border-top-right-radius: var(--primer-borderRadius-medium, 6px); + border-top-left-radius: var(--borderRadius-medium, 6px); + border-top-right-radius: var(--borderRadius-medium, 6px); &::before { - border-top-left-radius: var(--primer-borderRadius-medium, 6px); + border-top-left-radius: var(--borderRadius-medium, 6px); } } &:last-child { border-bottom: 0; - border-bottom-right-radius: var(--primer-borderRadius-medium, 6px); - border-bottom-left-radius: var(--primer-borderRadius-medium, 6px); + border-bottom-right-radius: var(--borderRadius-medium, 6px); + border-bottom-left-radius: var(--borderRadius-medium, 6px); &::before { - border-bottom-left-radius: var(--primer-borderRadius-medium, 6px); + border-bottom-left-radius: var(--borderRadius-medium, 6px); } } @@ -65,14 +65,14 @@ & .octicon { width: 16px; - margin-right: var(--primer-control-medium-gap, 8px); + margin-right: var(--control-medium-gap, 8px); color: var(--color-fg-muted); text-align: center; } & .Counter { float: right; - margin-left: var(--primer-control-small-gap, 4px); + margin-left: var(--control-small-gap, 4px); } & .menu-warning { @@ -82,7 +82,7 @@ & .avatar { float: left; - margin-right: var(--primer-control-small-gap, 4px); + margin-right: var(--control-small-gap, 4px); } &.alert { @@ -94,26 +94,26 @@ .menu-heading { display: block; - padding: var(--primer-control-medium-paddingInline-condensed, 8px) var(--primer-control-medium-paddingInline-spacious, 16px); + padding: var(--control-medium-paddingInline-condensed, 8px) var(--control-medium-paddingInline-spacious, 16px); margin-top: 0; margin-bottom: 0; font-size: inherit; font-weight: var(--base-text-weight-semibold, 600); color: var(--color-fg-default); - border-bottom: var(--primer-borderWidth-thin, 1px) solid var(--color-border-muted); + border-bottom: var(--borderWidth-thin, 1px) solid var(--color-border-muted); &:hover { text-decoration: none; } &:first-child { - border-top-left-radius: var(--primer-borderRadius-medium, 6px); - border-top-right-radius: var(--primer-borderRadius-medium, 6px); + border-top-left-radius: var(--borderRadius-medium, 6px); + border-top-right-radius: var(--borderRadius-medium, 6px); } &:last-child { border-bottom: 0; - border-bottom-right-radius: var(--primer-borderRadius-medium, 6px); - border-bottom-left-radius: var(--primer-borderRadius-medium, 6px); + border-bottom-right-radius: var(--borderRadius-medium, 6px); + border-bottom-left-radius: var(--borderRadius-medium, 6px); } } diff --git a/app/components/primer/alpha/segmented_control.pcss b/app/components/primer/alpha/segmented_control.pcss index baafb60df8..17d8e754eb 100644 --- a/app/components/primer/alpha/segmented_control.pcss +++ b/app/components/primer/alpha/segmented_control.pcss @@ -4,15 +4,15 @@ display: inline-flex; list-style: none; background-color: var(--color-segmented-control-bg); - border-radius: var(--primer-borderRadius-medium, 6px); + border-radius: var(--borderRadius-medium, 6px); } .SegmentedControl-item { position: relative; display: inline-flex; - border: var(--primer-borderWidth-thin, max(1px, 0.0625rem)) solid transparent; - border-radius: var(--primer-borderRadius-medium, 6px); - padding: var(--primer-control-xsmall-paddingInline-condensed, 4px); + border: var(--borderWidth-thin, max(1px, 0.0625rem)) solid transparent; + border-radius: var(--borderRadius-medium, 6px); + padding: var(--control-xsmall-paddingInline-condensed, 4px); /* Selected ---------------------------------------- */ &.SegmentedControl-item--selected { @@ -49,10 +49,10 @@ &::before { position: absolute; inset: 0 0 0 -1px; - margin-top: var(--primer-control-medium-paddingBlock, 6px); - margin-bottom: var(--primer-control-medium-paddingBlock, 6px); + margin-top: var(--control-medium-paddingBlock, 6px); + margin-bottom: var(--control-medium-paddingBlock, 6px); content: ''; - border-left: var(--primer-borderWidth-thin, max(1px, 0.0625rem)) solid var(--color-border-default); + border-left: var(--borderWidth-thin, max(1px, 0.0625rem)) solid var(--color-border-default); } /* Button ----------------------------------------- */ @@ -63,78 +63,67 @@ color: var(--color-btn-text); &:focus-visible { - outline-offset: calc( - var(--primer-control-xsmall-paddingInline-condensed, 4px) - var(--primer-borderWidth-thin, 1px) - ); - border-radius: calc(var(--primer-borderRadius-medium, 6px) - 5px); + outline-offset: calc(var(--control-xsmall-paddingInline-condensed, 4px) - var(--borderWidth-thin, 1px)); + border-radius: calc(var(--borderRadius-medium, 6px) - 5px); } } & .Button--small { height: calc( - var(--primer-control-small-size, 28px) - var(--primer-control-xsmall-paddingInline-condensed, 4px) * 2 - - var(--primer-borderWidth-thin, 1px) * 2 + var(--control-small-size, 28px) - var(--control-xsmall-paddingInline-condensed, 4px) * 2 - + var(--borderWidth-thin, 1px) * 2 ); padding: 0 - calc( - var(--primer-control-small-paddingInline-condensed, 8px) - - var(--primer-control-xsmall-paddingInline-condensed, 4px) - ); + calc(var(--control-small-paddingInline-condensed, 8px) - var(--control-xsmall-paddingInline-condensed, 4px)); &.Button--iconOnly { width: calc( - var(--primer-control-medium-size, 32px) - var(--primer-control-xsmall-paddingInline-condensed, 4px) * 2 - - var(--primer-borderWidth-thin, 1px) * 2 + var(--control-medium-size, 32px) - var(--control-xsmall-paddingInline-condensed, 4px) * 2 - + var(--borderWidth-thin, 1px) * 2 ); &::before { - @mixin minTouchTarget var(--primer-control-medium-size, 32px), var(--primer-control-medium-size, 32px); + @mixin minTouchTarget var(--control-medium-size, 32px), var(--control-medium-size, 32px); } } } & .Button--medium { height: calc( - var(--primer-control-medium-size, 32px) - var(--primer-control-xsmall-paddingInline-condensed, 4px) * 2 - - var(--primer-borderWidth-thin, 1px) * 2 + var(--control-medium-size, 32px) - var(--control-xsmall-paddingInline-condensed, 4px) * 2 - + var(--borderWidth-thin, 1px) * 2 ); padding: 0 - calc( - var(--primer-control-medium-paddingInline-normal, 12px) - - var(--primer-control-xsmall-paddingInline-condensed, 4px) - ); + calc(var(--control-medium-paddingInline-normal, 12px) - var(--control-xsmall-paddingInline-condensed, 4px)); &.Button--iconOnly { width: calc( - var(--primer-control-medium-size, 32px) - var(--primer-control-xsmall-paddingInline-condensed, 4px) * 2 - - var(--primer-borderWidth-thin, 1px) * 2 + var(--control-medium-size, 32px) - var(--control-xsmall-paddingInline-condensed, 4px) * 2 - + var(--borderWidth-thin, 1px) * 2 ); &::before { - @mixin minTouchTarget var(--primer-control-medium-size, 32px), var(--primer-control-medium-size, 32px); + @mixin minTouchTarget var(--control-medium-size, 32px), var(--control-medium-size, 32px); } } } & .Button--large { height: calc( - var(--primer-control-large-size, 40px) - var(--primer-control-xsmall-paddingInline-condensed, 4px) * 2 - - var(--primer-borderWidth-thin, 1px) * 2 + var(--control-large-size, 40px) - var(--control-xsmall-paddingInline-condensed, 4px) * 2 - + var(--borderWidth-thin, 1px) * 2 ); padding: 0 - calc( - var(--primer-control-large-paddingInline-spacious, 16px) - - var(--primer-control-xsmall-paddingInline-condensed, 4px) - ); + calc(var(--control-large-paddingInline-spacious, 16px) - var(--control-xsmall-paddingInline-condensed, 4px)); &.Button--iconOnly { width: calc( - var(--primer-control-large-size, 40px) - var(--primer-control-xsmall-paddingInline-condensed, 4px) * 2 - - var(--primer-borderWidth-thin, 1px) * 2 + var(--control-large-size, 40px) - var(--control-xsmall-paddingInline-condensed, 4px) * 2 - + var(--borderWidth-thin, 1px) * 2 ); &::before { - @mixin minTouchTarget var(--primer-control-large-size, 40px), var(--primer-control-large-size, 40px); + @mixin minTouchTarget var(--control-large-size, 40px), var(--control-large-size, 40px); } } } diff --git a/app/components/primer/alpha/tab_nav.pcss b/app/components/primer/alpha/tab_nav.pcss index 7d615baa3c..ec57dcd491 100644 --- a/app/components/primer/alpha/tab_nav.pcss +++ b/app/components/primer/alpha/tab_nav.pcss @@ -3,26 +3,26 @@ /* Outer wrapper */ .tabnav { margin-top: 0; - margin-bottom: var(--primer-stack-gap-normal, 16px); - border-bottom: var(--primer-borderWidth-thin, 1px) solid var(--color-border-default); + margin-bottom: var(--stack-gap-normal, 16px); + border-bottom: var(--borderWidth-thin, 1px) solid var(--color-border-default); } .tabnav-tabs { display: flex; - margin-bottom: calc(var(--primer-borderWidth-thin, 1px) * -1); + margin-bottom: calc(var(--borderWidth-thin, 1px) * -1); overflow: auto; } .tabnav-tab { display: inline-block; flex-shrink: 0; - padding: var(--base-size-8, 8px) var(--primer-control-medium-paddingInline-spacious, 16px); - font-size: var(--primer-text-body-size-medium, 14px); + padding: var(--base-size-8, 8px) var(--control-medium-paddingInline-spacious, 16px); + font-size: var(--text-body-size-medium, 14px); line-height: 23px; color: var(--color-fg-muted); text-decoration: none; background-color: transparent; - border: var(--primer-borderWidth-thin, 1px) solid transparent; + border: var(--borderWidth-thin, 1px) solid transparent; border-bottom: 0; transition: color 0.2s cubic-bezier(0.3, 0, 0.5, 1); @@ -32,7 +32,7 @@ color: var(--color-fg-default); background-color: var(--color-canvas-default); /* cover bottom border */ border-color: var(--color-border-default); - border-radius: var(--primer-borderRadius-medium, 6px) var(--primer-borderRadius-medium, 6px) 0 0; + border-radius: var(--borderRadius-medium, 6px) var(--borderRadius-medium, 6px) 0 0; & .octicon { color: inherit; @@ -47,7 +47,7 @@ &:focus, &:focus-visible { - border-radius: var(--primer-borderRadius-medium, 6px) var(--primer-borderRadius-medium, 6px) 0 0 !important; + border-radius: var(--borderRadius-medium, 6px) var(--borderRadius-medium, 6px) 0 0 !important; outline-offset: -6px; } @@ -56,12 +56,12 @@ } & .octicon { - margin-right: var(--primer-control-small-gap, 4px); + margin-right: var(--control-small-gap, 4px); color: var(--color-fg-muted); } & .Counter { - margin-left: var(--primer-control-small-gap, 4px); + margin-left: var(--control-small-gap, 4px); color: inherit; } } @@ -75,7 +75,7 @@ display: inline-block; padding-top: 10px; margin-left: 10px; - font-size: var(--primer-text-body-size-small, 12px); + font-size: var(--text-body-size-small, 12px); color: var(--color-fg-muted); & > .octicon { @@ -96,5 +96,5 @@ a.tabnav-extra:hover { ** the buttons to be floated or inline-block. */ .tabnav-btn { - margin-left: var(--primer-controlStack-medium-gap-condensed, 8px); + margin-left: var(--controlStack-medium-gap-condensed, 8px); } diff --git a/app/components/primer/alpha/text_field.pcss b/app/components/primer/alpha/text_field.pcss index 4cd107a849..255bd3aa59 100644 --- a/app/components/primer/alpha/text_field.pcss +++ b/app/components/primer/alpha/text_field.pcss @@ -14,9 +14,9 @@ /*