Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Deploy sketches live to remote instances -- with proof of concept #1817

Open
jgrizou opened this issue Mar 17, 2021 · 5 comments

Comments

@jgrizou
Copy link

jgrizou commented Mar 17, 2021

Nature of issue?

  • New feature request

New feature details:

A new option in the share menu to share a "live version". A live version host a "deployed" version of the sketch that is automatically refreshed when the user hit the deploy button.

This is useful when your work is hard to access physically but needs to be debugged/tweaked interactively and iteratively.

This is similar in concept with #1651 and #166. To explain the idea better, I developed and host p5live. p5live allows you to host live versions of your sketches, and each time you press play in the editor, all live versions will refresh automatically.

p5live_intro

For more details and testing see:

p5live_animation

Technical implementation

I am sharing here my implementation details, as a possible route for implementing within the editor and depending on your current roadmap.

As a hack around, I implemented p5live on my own server and it requires adding a small piece of code in the sketch.js code, see:

socket io_flow

The p5live version is a full screen embedding (via iframe) of the user sketch. This page connect to a server and listen to reload events. When a reload event is received, the iframe is refreshed and the lastest version of the p5.js sketch is shown.

To trigger the reload event, we need to add a small code on the sketch.js as follows

// we check if this is running in the editor
if (location.href == 'about:srcdoc') {
  // if yes, we connect ot the socket.io server
  const socket = io("https://p5live.jgrizou.repl.co/");
  socket.on('connect', () => {
    // on connect, we emit a reload message for our sketch
    socket.emit('reload', { username : YOUR_USERNAME, sketchId : YOUR_SKETCH_ID });
  });
}

This is a bit hacky but works very well which might help the community decide if this functionality is useful.

Suggested integration

In light of #1651 and #166, and because my background is in robotics, I can see this added as a third button on the interface called "upload" or "deploy" that explicit push the current version to all remote live instances of the sketch. A bit like when programming an Arduino board. This allows to develop locally, and deploy to all remote instances the work is displayed on.

upload

More details at https://github.com/jgrizou/p5live#next

Thanks

I hope this will be of help to the community and I would be very happy to help in working out how to best implement this in the editor.

Thanks for all the work the p5js community is doing!

@welcome
Copy link

welcome bot commented Mar 17, 2021

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@catarak
Copy link
Member

catarak commented Mar 18, 2021

Thank you for making this and thank you for sharing this!!!! This is so rad and I would love to integrate this with the web editor. I've been slowly but surely working on #166 which will affect this but in a small way (the URL for the iframe embed will change).

@sflanker
Copy link

FYI @jgrizou, you've got a bit of a name collision with the preexisting https://teddavis.org/p5live/

@jgrizou
Copy link
Author

jgrizou commented May 13, 2021

FYI @jgrizou, you've got a bit of a name collision with the preexisting https://teddavis.org/p5live/

Yeah didn't see it before :/ Let's live with it, I am not pushing this as a product/service, just to show a concept here. If it turns out to be useful it might be integrated in the official editor at some point.

@kjhollen
Copy link
Member

Just making a note that this is related to #1337!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants