Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HashLengthAndBase64Value() needs to be reimplemented #108

Closed
pan-apple opened this issue Mar 24, 2020 · 3 comments
Closed

HashLengthAndBase64Value() needs to be reimplemented #108

pan-apple opened this issue Mar 24, 2020 · 3 comments
Labels
feature work p1 priority 1 work question Further information is requested
Milestone
V1.0

Comments

@pan-apple
Copy link
Contributor

Problem

#104 deleted implementation of HashLengthAndBase64Value() and corresponding calls to it. This was done because Platform::Security module is not available.

Proposed Solution

Reimplement the function with available APIs. Add the calls to function from where it was removed.

Deleted code reference:
https://github.com/project-chip/connectedhomeip/blob/master/src/include/platform/internal/GenericConfigurationManagerImpl.ipp#L1053
@rwalker-apple rwalker-apple added this to the M4 milestone Mar 25, 2020
@rwalker-apple
Copy link
Contributor

@pan-apple can you re-assess this, please?

@woody-apple woody-apple modified the milestones: Not sure when, V1.0 May 26, 2020
@woody-apple woody-apple added the p1 priority 1 work label Oct 16, 2020
@woody-apple woody-apple added the question Further information is requested label Nov 5, 2020
@woody-apple
Copy link
Contributor

ping @pan-apple ?

@pan-apple
Copy link
Contributor Author

We can close this issue, as this code is not relevant for CHIP.

domichae-amazon pushed a commit to domichae-amazon/connectedhomeip that referenced this issue Mar 1, 2023
@sharadb-amazon
Android tv-casting-app: Adding defensive checks in DiscoveredNodeData…
c06f508 
… constructor (project-chip#108)

* Android tv-casting-app: Adding defensive null checks in DiscoveredNodeData constructor

* Adding more defensive checks / exception handling
chrisdecenzo pushed a commit that referenced this issue Mar 7, 2023
@sharadb-amazon
Android/tv-casting-app: Adding defensive checks in Discovery/record p…
bfd9b2e 
…arsing (#25464)

* Checking if multicastLock isHeld before trying to release it, avoiding stopServiceDiscovery call if discovery failed to start

* Android tv-casting-app: Adding defensive checks in DiscoveredNodeData constructor (#108)

* Android tv-casting-app: Adding defensive null checks in DiscoveredNodeData constructor

* Adding more defensive checks / exception handling
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
@sharadb-amazon
Android/tv-casting-app: Adding defensive checks in Discovery/record p…
1725dc5 
…arsing (project-chip#25464)

* Checking if multicastLock isHeld before trying to release it, avoiding stopServiceDiscovery call if discovery failed to start

* Android tv-casting-app: Adding defensive checks in DiscoveredNodeData constructor (project-chip#108)

* Android tv-casting-app: Adding defensive null checks in DiscoveredNodeData constructor

* Adding more defensive checks / exception handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature work p1 priority 1 work question Further information is requested
Projects
None yet
Milestone
V1.0
Development

No branches or pull requests
3 participants
@woody-apple @pan-apple @rwalker-apple