Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only call MatterReportingAttributeChangeCallback on write if the data version changes. #13013

Open
bzbarsky-apple opened this issue Dec 14, 2021 · 5 comments

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

Right now we have two places where writes can call MatterReportingAttributeChangeCallback:

  1. WriteSingleClusterData
  2. emAfWriteAttribute

Both call it unconditionally, even if the value being written is identical to the current value.

Proposed Solution

Once we have dataversion support, read the dataversion, then write the value, then read the dataversion and only report if it has changed.

@stale
Copy link

stale bot commented Sep 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Sep 17, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Sep 20, 2022
@stale
Copy link

stale bot commented Mar 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Mar 22, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Mar 23, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 15, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Oct 16, 2023
@bzbarsky-apple
Copy link
Contributor Author

Note: the implementation proposed above does not work, because we actually update data version from inside MatterReportingAttributeChangeCallback nowadays.

@tcarmelveilleux
Copy link
Contributor

Overall: this is the largest cause of needless reports, and fixing this will have a big impact on reducing congestion for large fan-outs of lighting commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants