-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only call MatterReportingAttributeChangeCallback on write if the data version changes. #13013
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Note: the implementation proposed above does not work, because we actually update data version from inside MatterReportingAttributeChangeCallback nowadays. |
Overall: this is the largest cause of needless reports, and fixing this will have a big impact on reducing congestion for large fan-outs of lighting commands. |
Problem
Right now we have two places where writes can call
MatterReportingAttributeChangeCallback
:WriteSingleClusterData
emAfWriteAttribute
Both call it unconditionally, even if the value being written is identical to the current value.
Proposed Solution
Once we have dataversion support, read the dataversion, then write the value, then read the dataversion and only report if it has changed.
The text was updated successfully, but these errors were encountered: