Ensure That the QRCode Library Is Built before Recursive Targets Are Run #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerickson
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
tpmanley and
woody-apple
as code owners
| @@ -48,4 +48,6 @@ dist_libQrCode_a_HEADERS = \ | |||
| QRCodeSetupPayloadParser.h \ | |||
| $(NULL) | |||
|
|
|||
| $(RECURSIVE_TARGETS): $(lib_LIBRARIES) | |||
There was a problem hiding this comment.
can you translate this into human form? does this "export" a recursive target to the rest of the make system, or?
There was a problem hiding this comment.
This basically says that before make executes all-recursive, dist-recursive, check-recursive, *-recursive (all of which operate on SUBDIRS), that the lib_LIBRARIES targets are up to date.
There was a problem hiding this comment.
the tests/... subdir here doesn't use the .a file, though, right?
woody-apple
approved these changes
Apr 1, 2020
BroderickCarlin
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is possible for recursive targets for the build system to attempt to run things in tests before the QRCode library is built.
Summary of Changes
This adds a dependency on all recursive targets on the QRCode library.
Fixes #191