Should ErrorStr be calling assertChipStackLockedByCurrentThread?

[vivien-apple]

Problem

While working on #25155 I end up with some Tsan data races when logging errors.

It seems that

connectedhomeip/src/lib/support/ErrorStr.cpp

Line 57 in 61cf6f2

DLL_EXPORT const char * ErrorStr(CHIP_ERROR err)

use a static buffer under the hood which is not thread safe.

We could probably add assertChipStackLockedByCurrentThread to ErrorStr but I suspect that in our current examples there are various places where this is used from the main thread.

Maybe we can just allow to pass an optional application owned buffer to ErrorStr too.

[bzbarsky-apple]

When I try making that assert, as in #25313, various things fail.....

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.