Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scenes] AttributeID in AttributeValuePair should not be optional #27076

Closed
lpbeliveau-silabs opened this issue Jun 5, 2023 · 2 comments
Closed

[Scenes] AttributeID in AttributeValuePair should not be optional #27076

lpbeliveau-silabs opened this issue Jun 5, 2023 · 2 comments
Labels
scenes Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation

Comments

@lpbeliveau-silabs
Copy link
Contributor

lpbeliveau-silabs commented Jun 5, 2023 •
edited
Loading

Currently in the data model, attributeID is optional, which doesn't respect the scenes cluster specification. It needs to be refactored to the AttributeId type.
@lpbeliveau-silabs lpbeliveau-silabs mentioned this issue Jun 5, 2023
Merged
@bzbarsky-apple
Copy link
Contributor

It should be of type attrib_id, no? Just not optional. That's in the XML. On the C++ side it would be AttributeId.

@bzbarsky-apple bzbarsky-apple added spec Mismatch between spec and implementation Spec XML align SDK XML does not match the spec (including naming, etc) labels Jun 5, 2023
@bzbarsky-apple bzbarsky-apple changed the title [Scenes] AttributeID in AttributeValuePair is optionnal [Scenes] AttributeID in AttributeValuePair should not be optional Jun 5, 2023
@lpbeliveau-silabs lpbeliveau-silabs mentioned this issue Jun 27, 2023
Merged
@lpbeliveau-silabs
Copy link
Contributor Author

Fixed in PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scenes Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation
Projects
[Enhancements] Spec/XML Alignment
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@woody-apple @bzbarsky-apple @lpbeliveau-silabs