Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReadHandler] Remove timing related flags #28129

Closed
lpbeliveau-silabs opened this issue Jul 20, 2023 · 1 comment · Fixed by #28421
Closed

[ReadHandler] Remove timing related flags #28129

lpbeliveau-silabs opened this issue Jul 20, 2023 · 1 comment · Fixed by #28421

Comments

@lpbeliveau-silabs
Copy link
Contributor

lpbeliveau-silabs commented Jul 20, 2023

Mentionned here: https://github.com/project-chip/connectedhomeip/pull/28104/files#r1269742928

TestReadInteraction relies on flags to simulate expiration of ReadHandler timers, they have been migrated to the ReadHandlerNode object of the ReportScheduler and additionnal test code was ifdefed in to allow those flags to work as they were originally implemented.

We need to remove all code in the #ifdef CONFIG_BUILD_FOR_HOST_UNIT_TEST and modify our test to stop relying on the flags.

Easiest way would be to have the test wait for the timers to elapse but that would slow down a test that is already slow.

Other options would be: modify the timestamps to be <= now and ensure to call the appropriate callbacks if expiration is supposed to have happen, manually bump up the timestamp, change the concept of "now" in checks for reportability.

@lpbeliveau-silabs
Copy link
Contributor Author

Will help reduce ram usage for : #28277

@mergify mergify bot closed this as completed in #28421 Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant