Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scenes] Increase YAML CI timers #29912

Closed
lpbeliveau-silabs opened this issue Oct 23, 2023 · 2 comments
Closed

[Scenes] Increase YAML CI timers #29912

lpbeliveau-silabs opened this issue Oct 23, 2023 · 2 comments

Comments

@lpbeliveau-silabs
Copy link
Contributor

lpbeliveau-silabs commented Oct 23, 2023

Some of the transition check timers are tight for the scenes yaml tests.
To avoid some unwanted failures in CI, we should bump them all to at least 250ms higher than their transition times.
Example:
Move to level with transition time of 1s -> CI should wait 1.25s to ensure the move to level is complete before checking again.

@lpbeliveau-silabs
Copy link
Contributor Author

Aims to prevent issues like the one mentionned in this PR: #29910

@lpbeliveau-silabs
Copy link
Contributor Author

#29910 Actually adjusted the only timer that was too tight, others were already increased enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant