-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix constraint type checks for command responses. #30218
Merged
lpbeliveau-silabs
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-contains-for-command-responses
Nov 6, 2023
Merged
Fix constraint type checks for command responses. #30218
lpbeliveau-silabs
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-contains-for-command-responses
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a command response, the YAML parser was ending up with the wrong type definition (the one for the whole command response, not the one for the one field) when a type-dependent constraint was used on a field of the response. This led to issues when a type-dependent constraint (like "contains") was used with a list of structs: the field names for the structs were not found, since the object used for lookup had field names for the command itself, not for the field in question. Fixes project-chip#30204
PR #30218: Size comparison from c797cb1 to ae1bfff Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Nov 5, 2023
yunhanw-google
approved these changes
Nov 6, 2023
lpbeliveau-silabs
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a command response, the YAML parser was ending up with the wrong type definition (the one for the whole command response, not the one for the one field) when a type-dependent constraint was used on a field of the response. This led to issues when a type-dependent constraint (like "contains") was used with a list of structs: the field names for the structs were not found, since the object used for lookup had field names for the command itself, not for the field in question.
Fixes #30204