Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few follow ups on top of #32516 #33549

Open
shubhamdp opened this issue May 22, 2024 · 0 comments
Open

Few follow ups on top of #32516 #33549

shubhamdp opened this issue May 22, 2024 · 0 comments

Comments

@shubhamdp
Copy link
Contributor

shubhamdp commented May 22, 2024 •
edited
Loading 

Suggest using plain old `unittest` module to convert the tests in here. Can be done as a follow-up.

Originally posted by @tcarmelveilleux in #32516 (comment)

Also suggest using @dataclass (Data classes) for these (as a follow-up) and use dataclasses.asdict(x) to dict-ify them for dicts versions.

Originally posted by @tcarmelveilleux in #32516 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shubhamdp