Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Update code generation MATTER_DM_PLUGIN_ #33659

Open
lpbeliveau-silabs opened this issue May 29, 2024 · 0 comments
Open

[Tooling] Update code generation MATTER_DM_PLUGIN_ #33659

lpbeliveau-silabs opened this issue May 29, 2024 · 0 comments
Assignees

Comments

@lpbeliveau-silabs
Copy link
Contributor

Reproduction steps / Feature

Add an #ifdef MATTER_DM_PLUGIN_ without #include <app/util/config.h> defined previously in the path.

Platform

core (please add to version below)

Platform Version(s)

1.3

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

Any use of #ifdef MATTER_DM_PLUGIN_ relies on #include <app/util/config.h> to be present somewhere before the ifdef to function properly.

We should update our code generation to generate #define MATTER_DM_PLUGIN_ 1 when the cluster is enabled and 0 otherwise so we can use #if MATTER_DM_PLUGIN_ instead, which will fail in the event #include <app/util/config.h> is not on the path as expected.

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant