Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] possibly stray leftovers of darwin-x64 that should be darwin-arm64? #33850

Open
ndyck14 opened this issue Jun 11, 2024 · 1 comment
Labels
darwin documentation Improvements or additions to documentation linux needs triage

Comments

@ndyck14
Copy link

ndyck14 commented Jun 11, 2024

Documentation issues

instructions provided on https://github.com/project-chip/connectedhomeip/tree/master/examples/all-clusters-app/linux

mentioned to use target as darwin-x64-all-clusters-no-ble-asan-clang for macOS.

This results in

Error: Invalid value for '--target': 'darwin-x64-all-clusters-no-ble-asan-clang' is not a valid target name.

It seems the correct target name is actually darwin-arm64-all-clusters-no-ble-asan-clang (x64 --> arm64)

This seems potentially trivial, although darwin-x64 is used in a number of places in yaml files. Not sure if it was changed somewhere along the way, just not everywhere? Or if there is otherwise a proper disctinction. Perhaps @bzbarsky-apple or @jtung-apple have insight?

Platform

darwin

Anything else?

No response

@ndyck14 ndyck14 added documentation Improvements or additions to documentation needs triage labels Jun 11, 2024
@ndyck14 ndyck14 changed the title [Documentation] [Documentation] possibly stray leftovers of darwin-x64 that should be darwin-arm64? Jun 11, 2024
@bzbarsky-apple
Copy link
Contributor

It seems the correct target name is actually darwin-arm64-all-clusters-no-ble-asan-clang (x64 --> arm64)

That depends on whether you're on an Intel or ARM Mac, right?

CI uses darwin-x64 because the things it's running on have Intel processors. If you're on an Intel mbp/air/whatever, darwin-x64 is the right thing. If you're on an M1/2/3/etc laptop darwin-arm64 is the right thing.

@ndyck14 I agree the docs should be clearer about this. Do you want to fix them up, or should I do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
darwin documentation Improvements or additions to documentation linux needs triage
Projects
Status: Todo
Development

No branches or pull requests

2 participants