Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEM Modes don't state that they should be mandatory #33890

Closed
jamesharrow opened this issue Jun 12, 2024 · 2 comments
Closed

DEM Modes don't state that they should be mandatory #33890

jamesharrow opened this issue Jun 12, 2024 · 2 comments

Comments

@jamesharrow
Copy link
Contributor

The intention of the DEM Mode cluster was to address a 1.3 security threat model review, in that consumers should explicitly have control on if they want their device to be remotely controllable.

Hence we added the DEM Mode cluster with some 'example' tags.

However the DEM Spec now expects all commands to be checked against the OptOutStateEnum which is a Read-only attribute.

The intent of the DEM Modes was to allow the user to change the opt-out mode, but it looks like nothing in the spec mandates the inclusion of these specific modes.

I believe we should add this to tighten up and ensure products don't ship without these modes.
Potentially we need a test case to validate that these modes SHALL be included - but not sure how to mandate specific modes are included. Does this go in the Device Type? Or the Mode cluster (remove the word 'examples' might help).

@ReneJosefsen
Copy link
Contributor

Should this have been a spec issue?

@jamesharrow
Copy link
Contributor Author

Should this have been a spec issue?

Yes - I added it using the Github project view and it accidentally ended up here.
I'll remove and repost it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants