Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2] [TC-LVL-3.1] Logic of Step 5f - 5j #33918

Closed
lecndav opened this issue Jun 14, 2024 · 7 comments
Closed

[1.2] [TC-LVL-3.1] Logic of Step 5f - 5j #33918

lecndav opened this issue Jun 14, 2024 · 7 comments
Labels

Comments

@lecndav
Copy link

lecndav commented Jun 14, 2024

Feature Area

Other

Test Case

TC-LVL-3.1

Reproduction steps

Test step 5a writes 0x00 to the options attribute which disables execution if the EP is off. Step 5f sends an off command and after that a MoveToLevel (level to 120) command without any options modification gets sent. Because the options attribute is 0x00 and the EP is off nothing happens. The next test step though expects the current level to be 120. Same goes for the next two step respectively.
Step 5k sends along the MoveToLevel command an option override which enables execution if off. Step 5l succeeds because the new level gets applied.

In my perspective either the test step sequence is wrong or the expected return values a wrong.

I suggest to modify the expected current level values of the test steps 5h and 5j to be 1 (off). This ensures that the behaviour with options = 0x00 is correct and also if a command overrides the options attribute.

Bug prevalence

every time

GitHub hash of the SDK that was being used

ce7d400

Platform

darwin

Anything else?

No response

@lecndav lecndav added bug Something isn't working cert blocker needs triage labels Jun 14, 2024
@lecndav lecndav changed the title [CERT-TEST-FAILURE] TC-LVL-3.1 Step 5f - 5j [1.2] [TC-LVL-3.1] Logic of Step 5f - 5j Jun 14, 2024
@lecndav
Copy link
Author

lecndav commented Jun 14, 2024

In the same context: Test step 6j fails because it expects the previous MoveToLevel command not to be executed, but it is. Therefore the read value is considered wrong.

@ReneJosefsen
Copy link
Contributor

Should this be a test plan issue?

@lecndav
Copy link
Author

lecndav commented Jun 17, 2024

In my perspective this is a test plan issue because the current test procedure is not compliant to the matter spec.

@ReneJosefsen
Copy link
Contributor

Can you raise this issue on the test plan repo?

@ReneJosefsen
Copy link
Contributor

Looking at this, 5g does a MoveToLevel to Level=120 and states in the expected outcome is "that the device remains in the off state."

5h then reads currentLevel and states: "Verify that the DUT response indicates that the CurrentLevel attribute (still) has the value given in 5d." and from what I can see they YAML also expects 100? This is also the case for 5i and 5j?

@lecndav
Copy link
Author

lecndav commented Jun 18, 2024

Well, maybe I have misinterpreted the standard. If a device receives an off command, it does not mean that the current level set to minimum? So if a MoveToLevel command gets sent, the current level gets updated but the device still remains off? Except when the ExecuteIfOff option is set?

@lecndav
Copy link
Author

lecndav commented Jun 19, 2024

After rereading the spec more carefully I have a better understanding of the dependency between the OnOff and LevelControl cluster now. I initially derived the OnOff attribute from the current level. But these attributes should be treated separately.

Sorry for the confusion, the test plan is correct.

@lecndav lecndav closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants