Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/common should go away #3470

Open
rwalker-apple opened this issue Oct 27, 2020 · 5 comments
Open

examples/common should go away #3470

rwalker-apple opened this issue Oct 27, 2020 · 5 comments
Labels
enhancement New feature or request future p3 priority 3 work V1.X
Milestone

Comments

@rwalker-apple
Copy link
Contributor

Problem

examples/common was created to hold third-party repositories, but now it's a place where a fair amount of CHIP code (i.e. that which should be supplied as part of CHIP) has landed

would be nice to see files that only depend on CHIP from examples/common moved into CHIP...

Originally posted by @rwalker-apple in #3468 (comment)

Suggested Changes

  1. move CHIP code that lives in examples/common into src/app
  2. move gitmodules out of examples/common and into third_party/XXX/repo and have each example application link from their third_party/ subdirectory to the CHIP location
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.89. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@rwalker-apple
Copy link
Contributor Author

@woody-apple woody-apple added enhancement New feature or request p3 priority 3 work and removed feature request labels Jan 29, 2021
@woody-apple woody-apple added this to the V1.0 milestone Jan 29, 2021
@stale
Copy link

stale bot commented Sep 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Sep 15, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Sep 20, 2022
@stale
Copy link

stale bot commented Mar 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Mar 22, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Mar 23, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 15, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future p3 priority 3 work V1.X
Projects
None yet
Development

No branches or pull requests

3 participants