Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chip prefix of all protocol IDs defined in CHIPProtocols.h and all of its reference #3479

Closed
yufengwangca opened this issue Oct 27, 2020 · 1 comment · Fixed by #3541
Closed

Remove chip prefix of all protocol IDs defined in CHIPProtocols.h and all of its reference #3479

yufengwangca opened this issue Oct 27, 2020 · 1 comment · Fixed by #3541
Assignees
@yufengwangca
Labels
feature request

Comments

@yufengwangca
Copy link
Contributor

Problem

no need to prefix those defines with CHIP, it's already in the CHIP namespace.

Proposed Solution

Remove the chip prefix and update all references
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.64. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@yufengwangca yufengwangca self-assigned this Oct 27, 2020
This was referenced Oct 27, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yufengwangca yufengwangca

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decouple CHIP stack from legacy WML based protocols
1 participant
@yufengwangca