You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The convention should be that the code should read like text, ideally. The needs ack case as currently defined ends up reading as "this payload header is needs ack", which is not very good English. "this payload header needs ack" is closer to what one would actually say.
Proposed Solution
Rename member function IsNeedsAck to NeedsAck in payloadHeader
The text was updated successfully, but these errors were encountered:
Problem
The convention should be that the code should read like text, ideally. The needs ack case as currently defined ends up reading as "this payload header is needs ack", which is not very good English. "this payload header needs ack" is closer to what one would actually say.
Proposed Solution
Rename member function IsNeedsAck to NeedsAck in payloadHeader
The text was updated successfully, but these errors were encountered: