Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename member function IsNeedsAck to NeedsAck in payloadHeader #4093

Closed
yufengwangca opened this issue Dec 4, 2020 · 2 comments · Fixed by #4739
Closed

Rename member function IsNeedsAck to NeedsAck in payloadHeader #4093

yufengwangca opened this issue Dec 4, 2020 · 2 comments · Fixed by #4739
Assignees

Comments

@yufengwangca
Copy link
Contributor

Problem

The convention should be that the code should read like text, ideally. The needs ack case as currently defined ends up reading as "this payload header is needs ack", which is not very good English. "this payload header needs ack" is closer to what one would actually say.

Proposed Solution

Rename member function IsNeedsAck to NeedsAck in payloadHeader

@woody-apple
Copy link
Contributor

@yufengwangca how does this interact with #4083?

@yufengwangca
Copy link
Contributor Author

They are not relevant, this function indicates if an incoming message needs ack, #4083 indicates if the incoming message contains ack info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants