Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a better way of expressing 'Optional' parameters in the Binding Cluster #4176

Open
vivien-apple opened this issue Dec 11, 2020 · 3 comments
Labels
enhancement New feature or request future V1.X
Milestone

Comments

@vivien-apple
Copy link
Contributor

I would prefer that we either explicitly use Optional to represent not-passed things here, or have a struct that can represent "either group id or (node, endpoint) pair" or something...

Probably ok to land as-is for now to unblock things, but please file a followup on fixing this?

Originally posted by @bzbarsky-apple in #4156 (comment)

@woody-apple woody-apple added V1.0 and removed V0.7 labels Feb 2, 2021
@woody-apple woody-apple added this to the V1.0 milestone Feb 2, 2021
@woody-apple woody-apple added the enhancement New feature or request label Feb 2, 2021
@woody-apple woody-apple removed the V1.0 label Oct 27, 2021
@stale
Copy link

stale bot commented Sep 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Sep 16, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Sep 20, 2022
@stale
Copy link

stale bot commented Mar 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Mar 22, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Mar 23, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 15, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future V1.X
Projects
None yet
Development

No branches or pull requests

3 participants