Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefix kSendFlag_ from enum class SendMessageFlag and kExchangeFlag_ from ExFlagValues #4201

Closed
yufengwangca opened this issue Dec 14, 2020 · 0 comments · Fixed by #4323
Assignees

Comments

@yufengwangca
Copy link
Contributor

yufengwangca commented Dec 14, 2020

Problem

enum class SendMessageFlags : uint16_t
{
kSendFlag_None = 0x0000,
/< Used to indicate that automatic retransmission is enabled. */
kSendFlag_AutoRetrans = 0x0001,
/
< Used to indicate that a response is expected within a specified timeout. */
kSendFlag_ExpectResponse = 0x0002,
/< Used to indicate that the sending of the current message needs to be delayed. */
kSendFlag_DelaySend = 0x0008,
/
< Used to indicate that the source node ID in the message header can be reused. */
kSendFlag_ReuseSourceId = 0x0020,
/< Used to indicate that the message is already encoded. */
kSendFlag_AlreadyEncoded = 0x0080,
/
< Used to indicate that default IPv6 source address selection should be used when sending IPv6 multicast messages. */
kSendFlag_DefaultMulticastSourceAddress = 0x0100,
/< Used to indicate that the current message is the initiator of the exchange. */
kSendFlag_FromInitiator = 0x0200,
/
< Used to send a ReliableMessageProtocol message requesting an acknowledgment. */
kSendFlag_RequestAck = 0x0400,
/**< Suppress the auto-request acknowledgment feature when sending a message. */
kSendFlag_NoAutoRequestAck = 0x0800,
};

The actual flag name should be SendMessageFlags::NoAutoRequestAck and similar for all the other flags. As in, the "kSendFlag_" part is redundant with the enum class name already.

Proposed Solution

Remove prefix kSendFlag_ from enum class SendMessageFlag and kExchangeFlag_ bit from ExFlagValues

@yufengwangca yufengwangca self-assigned this Dec 14, 2020
@yufengwangca yufengwangca changed the title Cleanup redundant SendMessageFlags from messaging layer Remove prefix kSendFlag_ from enum class SendMessageFlag and kExchangeFlag_ bit from ExFlagValues Dec 15, 2020
@yufengwangca yufengwangca changed the title Remove prefix kSendFlag_ from enum class SendMessageFlag and kExchangeFlag_ bit from ExFlagValues Remove prefix kSendFlag_ from enum class SendMessageFlag and kExchangeFlag_ from ExFlagValues Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant