You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
enum class SendMessageFlags : uint16_t
{
kSendFlag_None = 0x0000,
/< Used to indicate that automatic retransmission is enabled. */
kSendFlag_AutoRetrans = 0x0001,
/< Used to indicate that a response is expected within a specified timeout. */
kSendFlag_ExpectResponse = 0x0002,
/< Used to indicate that the sending of the current message needs to be delayed. */
kSendFlag_DelaySend = 0x0008,
/< Used to indicate that the source node ID in the message header can be reused. */
kSendFlag_ReuseSourceId = 0x0020,
/< Used to indicate that the message is already encoded. */
kSendFlag_AlreadyEncoded = 0x0080,
/< Used to indicate that default IPv6 source address selection should be used when sending IPv6 multicast messages. */
kSendFlag_DefaultMulticastSourceAddress = 0x0100,
/< Used to indicate that the current message is the initiator of the exchange. */
kSendFlag_FromInitiator = 0x0200,
/< Used to send a ReliableMessageProtocol message requesting an acknowledgment. */
kSendFlag_RequestAck = 0x0400,
/**< Suppress the auto-request acknowledgment feature when sending a message. */
kSendFlag_NoAutoRequestAck = 0x0800,
};
The actual flag name should be SendMessageFlags::NoAutoRequestAck and similar for all the other flags. As in, the "kSendFlag_" part is redundant with the enum class name already.
Proposed Solution
Remove prefix kSendFlag_ from enum class SendMessageFlag and kExchangeFlag_ bit from ExFlagValues
The text was updated successfully, but these errors were encountered:
yufengwangca
changed the title
Cleanup redundant SendMessageFlags from messaging layer
Remove prefix kSendFlag_ from enum class SendMessageFlag and kExchangeFlag_ bit from ExFlagValues
Dec 15, 2020
yufengwangca
changed the title
Remove prefix kSendFlag_ from enum class SendMessageFlag and kExchangeFlag_ bit from ExFlagValues
Remove prefix kSendFlag_ from enum class SendMessageFlag and kExchangeFlag_ from ExFlagValues
Jan 7, 2021
Problem
enum class SendMessageFlags : uint16_t
{
kSendFlag_None = 0x0000,
/< Used to indicate that automatic retransmission is enabled. */
kSendFlag_AutoRetrans = 0x0001,
/< Used to indicate that a response is expected within a specified timeout. */
kSendFlag_ExpectResponse = 0x0002,
/< Used to indicate that the sending of the current message needs to be delayed. */
kSendFlag_DelaySend = 0x0008,
/< Used to indicate that the source node ID in the message header can be reused. */
kSendFlag_ReuseSourceId = 0x0020,
/< Used to indicate that the message is already encoded. */
kSendFlag_AlreadyEncoded = 0x0080,
/< Used to indicate that default IPv6 source address selection should be used when sending IPv6 multicast messages. */
kSendFlag_DefaultMulticastSourceAddress = 0x0100,
/< Used to indicate that the current message is the initiator of the exchange. */
kSendFlag_FromInitiator = 0x0200,
/< Used to send a ReliableMessageProtocol message requesting an acknowledgment. */
kSendFlag_RequestAck = 0x0400,
/**< Suppress the auto-request acknowledgment feature when sending a message. */
kSendFlag_NoAutoRequestAck = 0x0800,
};
The actual flag name should be SendMessageFlags::NoAutoRequestAck and similar for all the other flags. As in, the "kSendFlag_" part is redundant with the enum class name already.
Proposed Solution
Remove prefix kSendFlag_ from enum class SendMessageFlag and kExchangeFlag_ bit from ExFlagValues
The text was updated successfully, but these errors were encountered: