Rename inappropriate member functions in ReliableMessageManager #4322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
mspang
approved these changes
Jan 12, 2021
kghost
approved these changes
Jan 12, 2021
andy31415
approved these changes
Jan 12, 2021
| void ClearRetransmitTable(ReliableMessageContext * rc); | ||
| void ClearRetransmitTable(RetransTableEntry & rEntry); | ||
| void FailRetransmitTableEntries(ReliableMessageContext * rc, CHIP_ERROR err); | ||
| void ClearRetransTable(ReliableMessageContext * rc); |
There was a problem hiding this comment.
Would there be any value to use full Retransmit/Retransmission instead of 'Retrans' here and on the data member name?
I also wonder if the name 'RetransTable' is an internal implementation detail and if the public API should should maybe not use 'Table' at all. Like
Some comments may also help: reading CheckAndRemRetransTable ... what does it check? Why Rem instead of Remove (assume rem stands for remove).
Likely for future PRs though. LGTM for this particular PR as being an improvement over the previous code.
rwalker-apple
approved these changes
Jan 12, 2021
saurabhst
approved these changes
Jan 12, 2021
|
@yufengwangca conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is the follow-up of the review comments in #4048
Summary of Changes
Fixes #4206