Use enum class to define protocols message type for strong typing #4593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
saurabhst,
wehale and
woody-apple
saurabhst
approved these changes
Feb 1, 2021
pan-apple
approved these changes
Feb 1, 2021
andy31415
reviewed
Feb 2, 2021
andy31415
approved these changes
Feb 2, 2021
bzbarsky-apple
previously requested changes
Feb 2, 2021
woody-apple
approved these changes
Feb 2, 2021
woody-apple
dismissed
bzbarsky-apple’s stale review
Review comments addressed
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
…oject-chip#4593) * Use enum class to define protocols message type for strong typing * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
…oject-chip#4593) * Use enum class to define protocols message type for strong typing * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 4, 2021
…oject-chip#4593) * Use enum class to define protocols message type for strong typing * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is follow-up of #4429 which defined a set of APIs that allow us to just pass in a strongly typed (enum class) message type and derive the protocol from the type of the message type. Currently, only SecureChannel protocol has been updated to use strongly typed (enum class) message type.
Summary of Changes
update all protocol message type to use strongly typed (enum class) message type.
Fixes #4592