Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging.cpp has lots of duplicated code across our platforms, feels like we should unify this #4624

Open
woody-apple opened this issue Feb 3, 2021 · 1 comment

Comments

@woody-apple
Copy link
Contributor

Problem

If you search through Logging.cpp in the platforms you'll see identical implementations of many logging functions:
eg:

void LogV(uint8_t module, uint8_t category, const char * aFormat, va_list v);

Proposed Solution

Many of which move around a lot of memory, and are naturally error prone. Let's have our bugs in one spot? :)

@woody-apple woody-apple added enhancement New feature or request platform p2 priority 2 work security memory labels Feb 3, 2021
@woody-apple woody-apple added this to the V1.0 milestone Feb 3, 2021
@woody-apple
Copy link
Contributor Author

Making this a P1, upon further inspection there are so many magic numbers, that I suspect there are already problems, plus every platform has different CHIP output, let's unify this.

@woody-apple woody-apple added p1 priority 1 work and removed p2 priority 2 work labels Feb 3, 2021
@woody-apple woody-apple added V1.X future V1.0 and removed p1 priority 1 work V1.X labels Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants