Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zap does not allow to set attribute of type ARRAY to writable #5311

Closed
yufengwangca opened this issue Mar 11, 2021 · 2 comments
Closed

zap does not allow to set attribute of type ARRAY to writable #5311

yufengwangca opened this issue Mar 11, 2021 · 2 comments
Assignees
Labels
stale Stale issue or PR V1.X

Comments

@yufengwangca
Copy link
Contributor

yufengwangca commented Mar 11, 2021

Problem

Currently, the attribute of type ARRAY can only be marked as readable, (writable="false" ), zap will complain unsupported type if I set it to (writable="true" )

Proposed Solution

zap should not complain if we set writable="true" for a attribute of type ARRAY

@stale
Copy link

stale bot commented Jul 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 25, 2022
@stale
Copy link

stale bot commented Oct 18, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issue or PR V1.X
Projects
None yet
Development

No branches or pull requests

3 participants