Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate better TLV API to SDK consumer #5447

Open
yunhanw-google opened this issue Mar 18, 2021 · 4 comments
Open

Investigate better TLV API to SDK consumer #5447

yunhanw-google opened this issue Mar 18, 2021 · 4 comments
Assignees
Labels

Comments

@yunhanw-google
Copy link
Contributor

I am very worried about exposing the raw TLV to SDK consumers. The TLV reader API is not particularly easy to use, unfortunately. Again, I guess we can do this for the moment, but it seems to me that we're eventually going to want a nicer API. What the size cost of that would be is a hard question, but I would really like something safer to use than "here, read some tlv; good luck", especially when the rules around reading TLV are not well-internalized even by CHIP developers and are not well-described in the spec.

#5198 (review)

@bzbarsky-apple
Copy link
Contributor

The real question is whether "here's the TLV for the event list" is the right API at all to expose as an external SDK API.

@stale
Copy link

stale bot commented Jul 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 25, 2022
@stale
Copy link

stale bot commented Oct 18, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 18, 2022
@stale stale bot removed the stale Stale issue or PR label Oct 20, 2022
@stale
Copy link

stale bot commented Apr 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Apr 19, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants