Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange context flags API is very verbose #6305

Open
bzbarsky-apple opened this issue Apr 27, 2021 · 3 comments
Open

Exchange context flags API is very verbose #6305

bzbarsky-apple opened this issue Apr 27, 2021 · 3 comments
Labels

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

ExchangeContext::SendMessage takes a flags arg of type SendFlags, which is a BitFlags<SendMessageFlags>

That means every call to this API has an arg that looks like SendFlags(SendMessageFlags:kSomething).

Proposed Solution

It looks like the BitFlags constructor that takes the enum value is explicit, but we could add overloads of SendMessage that take SendMessageFlags directly as a last arg to cut down on the extra verbosity at callsites.... Callsites that need more than one flag will still need to do something, of course (though if we wanted to we could make these overloads variadic templates that pass through all the remaining args to the SendFlags ctor.

@stale
Copy link

stale bot commented Jul 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 25, 2022
@stale
Copy link

stale bot commented Oct 18, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 18, 2022
@stale stale bot removed the stale Stale issue or PR label Oct 20, 2022
@stale
Copy link

stale bot commented Apr 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Apr 19, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants