Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Invoke Command Suppress response support #8043

Open
yunhanw-google opened this issue Jun 30, 2021 · 15 comments
Open

Add Invoke Command Suppress response support #8043

yunhanw-google opened this issue Jun 30, 2021 · 15 comments
Assignees
Labels

Comments

@yunhanw-google
Copy link
Contributor

Problem

there is spec conflict regarding suppress response flag in https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/3536, after the above issue is resolved, we would decide how to add Invoke Command Suppress response support.

@mrjerryjohns
Copy link
Contributor

Was resolved a while back.

@bzbarsky-apple
Copy link
Contributor

No, this is not supported. We parse it, but do absolutely nothing with it.

@Rajashreekalmane
Copy link

@bzbarsky-apple @mrjerryjohns In Spec mentioned suppress response is mandatory for invokerequest and write request message
image
Could you please let me know how to check whether DUT suppress its response when TH sends Invoke/write request with suppress response parameter set to bool.

@bzbarsky-apple
Copy link
Contributor

Could you please let me know how to check whether DUT suppress its response

Does the TH get a response? If so, the DUT did not suppress it.

@sankarselvam
Copy link

@bzbarsky-apple From my observation, DUT is not suppressing the response.
@Rajashreekalmane , Can you please attach the logs?

@bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple From my observation, DUT is not suppressing the response.

Right, that's why this issue is open!

@Rajashreekalmane , Can you please attach the logs?

There is no need to attach logs here.

@Rajashreekalmane
Copy link

Rajashreekalmane commented Jun 8, 2022

@bzbarsky-apple Could you please let me know what should I do in this case, Is this cert-blocker or V1.0 out of scope issue.

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Jun 8, 2022

So far it's being treated as out of scope. See the "v1.x" label.

@stale
Copy link

stale bot commented Dec 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Dec 10, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Dec 12, 2022
@vivien-apple
Copy link
Contributor

Just to make it clear, the chip-tool syntax for such a command is:

$ ./out/debug/standalone/chip-tool onoff toggle 0x12344321 1 --suppressResponse true

It does not work as of today because the stack does not supports suppress response. It can be observed that the value is set properly in the InvokeRequestMessage that is logged.

@stale
Copy link

stale bot commented Jun 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jun 15, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Jun 15, 2023
@woody-apple woody-apple removed the TE7.5 label Jul 17, 2023
@cjandhyala cjandhyala added this to the 1.3 milestone Jul 18, 2023
@VaishaliAvhale

This comment was marked as off-topic.

@bzbarsky-apple

This comment was marked as off-topic.

@VaishaliAvhale

This comment was marked as off-topic.

@VaishaliAvhale

This comment was marked as off-topic.

@woody-apple woody-apple removed the V1.X label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Open Cert Blockers
Development

No branches or pull requests

10 participants