Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Automerge might starve other workflows #475

Closed
galargh opened this issue Feb 23, 2023 · 1 comment · Fixed by #477
Closed

Automerge might starve other workflows #475

galargh opened this issue Feb 23, 2023 · 1 comment · Fixed by #477

Comments

@galargh
Copy link
Contributor

galargh commented Feb 23, 2023

Automerge keeps a runner occupied for as long as there are any outstanding checks on a PR. This could lead to starvation if automerge workflows get scheduled on all the runners. We haven't hit this yet but I saw cases where half the runners where automerge workflows.

Maybe we could periodically go through all the web3-bot PRs and merge them if all the checks are passing instead?
@galargh galargh mentioned this issue Feb 23, 2023
Merged
@galargh
Copy link
Contributor Author

galargh commented Aug 28, 2023

https://github.com/pl-strflt/uci doesn't have automerge 🥳

@galargh galargh closed this as completed Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace automerge with scheduled workflow living in this repo protocol/.github
1 participant
@galargh