Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark submodule fails to build on ppc64. #4244

Closed
mandlebug opened this issue Jan 29, 2018 · 2 comments
Closed

Benchmark submodule fails to build on ppc64. #4244

mandlebug opened this issue Jan 29, 2018 · 2 comments
Assignees

Comments

@mandlebug
Copy link

Building the Protobuf C++ benchmark on a PowerPC cpu fails because the submodule version of google/benchmark that protbuf uses is broken on powerpc. A Commit merged in #3822 was supposed to fix this but the submodule commit that the git link points to now is earlier then the commit needed to unbreak the PowerPC build.

git submodule status
-360e66c1c4777c99402cf8cd535aa510fee16573 third_party/benchmark

git show 360e66c1c4777c99402cf8cd535aa510fee16573
commit 360e66c1c4777c99402cf8cd535aa510fee16573
Merge: 336fd11 fa0e7ef
Author: Dominic Hamon <dominichamon@users.noreply.github.com>
Date:   Wed May 11 12:07:59 2016 -0700

The commit needed to fix the powerpc build is

commit fef203bd021bad019421abf5785a4ae89bd6ea15
Author: guray <guray.ozen@gmail.com>
Date:   Mon Jan 30 21:50:21 2017 +0100

    Fix typename for powerpc (#337)

@BSBandme
Copy link
Contributor

Sorry for the accident rolling back

@mandlebug
Copy link
Author

I've verified the fix by compiling natively on a Power8 machine. Thank you for the the fast turnaround, its appreciated!

@BSBandme BSBandme self-assigned this Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants