Skip to content

Latest commit

 

History

History
148 lines (96 loc) · 7.43 KB

CONTRIBUTING.md

File metadata and controls

148 lines (96 loc) · 7.43 KB
Raw

Contributing

First of all, thank you for contributing to Meilisearch! The goal of this document is to provide everything you need to know in order to contribute to Meilisearch and its different integrations.

Assumptions

  1. You're familiar with GitHub and the Pull Request(PR) workflow.
  2. You've read the Meilisearch documentation and the README.
  3. You know about the Meilisearch community. Please use this for help.

How to Contribute

  1. Make sure that the contribution you want to make is explained or detailed in a GitHub issue! Find an existing issue or open a new one.
  2. Once done, fork the docs-scraper repository in your own GitHub account. Ask a maintainer if you want your issue to be checked before making a PR.
  3. Create a new Git branch.
  4. Review the Development Workflow section that describes the steps to maintain the repository.
  5. Make the changes on your branch.
  6. Submit the branch as a PR pointing to the main branch of the main docs-scraper repository. A maintainer should comment and/or review your Pull Request within a few days. Although depending on the circumstances, it may take longer.
    We do not enforce a naming convention for the PRs, but please use something descriptive of your changes, having in mind that the title of your PR will be automatically added to the next release changelogs.

Development Workflow

Install and Launch

The pipenv command must be installed.

Set both environment variables MEILISEARCH_HOST_URL and MEILISEARCH_API_KEY.

Then, run:

pipenv install
pipenv run ./docs_scraper <path-to-your-config-file>

Linter and Tests 

pipenv install --dev
# Linter
pipenv run pylint scraper

If you have a chromedriver, you can run the full test suite by passing the path to your chromedriver.

pipenv run pytest --chromedriver=/path/to/your/chromedriver

Where path/to/your/chromedriver matches your particular path. If you are unsure of your chromedriver path you find it on Linux/Mac with:

which chromedriver

Or on Windwos with:

where chromedriver

It is possible when running the tests that an error occurs if your running chrome browser has a different version than your chromedriver. In which case, please download the adequate chromedriver.

If you do not have chromedriver installed you can skip the tests that require it by running the tests with:

pipenv run pytest -m "not chromedriver"

Note that these tests will still run in CI when you submit your pull request.

Optionally tox can be used to run test on all supported version of Python and linting.

pipenv run tox -- --chromedriver=/path/to/your/chromedriver

Or to run tox if you don't have chromedriver

pipenv run tox -- -m "not chromedriver"

Git Guidelines

Git Branches

All changes must be made in a branch and submitted as PR. We do not enforce any branch naming style, but please use something descriptive of your changes.

Git Commits

As minimal requirements, your commit message should:

  • be capitalized
  • not finish by a dot or any other punctuation character (!,?)
  • start with a verb so that we can read your commit message this way: "This commit will ...", where "..." is the commit message. e.g.: "Fix the home page button" or "Add more tests for create_index method"

We don't follow any other convention, but if you want to use one, we recommend this one.

GitHub Pull Requests

Some notes on GitHub PRs:

  • Convert your PR as a draft if your changes are a work in progress: no one will review it until you pass your PR as ready for review.
    The draft PR can be very useful if you want to show that you are working on something and make your work visible.
  • The branch related to the PR must be up-to-date with main before merging. Fortunately, this project integrates a bot to automatically enforce this requirement without the PR author having to do it manually.
  • All PRs must be reviewed and approved by at least one maintainer.
  • The PR title should be accurate and descriptive of the changes. The title of the PR will be indeed automatically added to the next release changelogs.

Release Process (for the internal team only)

Meilisearch tools follow the Semantic Versioning Convention.

Automation to Rebase and Merge the PRs

This project integrates a bot that helps us manage pull requests merging.
Read more about this.

Automated Changelogs

This project integrates a tool to create automated changelogs.
Read more about this.

How to Publish the Release

⚠️ Before doing anything, make sure you got through the guide about Releasing an Integration.

Make a PR modifying the file scraper/src/config/version.py with the right version.

__version__ = "X.X.X"

Once the changes are merged on main, you can publish the current draft release via the GitHub interface: on this page, click on Edit (related to the draft release) > update the description (be sure you apply these recommendations) > when you are ready, click on Publish release.

GitHub Actions will be triggered and push the latest and vX.X.X version of the Docker image to DockerHub.

Thank you again for reading this through. We can not wait to begin to work with you if you make your way through this contributing guide ❤️