Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcsam2p.ico hard link appears in sam2p-0.49.4.tar.gz #48

Closed
pts opened this issue Oct 3, 2018 · 2 comments
Closed

vcsam2p.ico hard link appears in sam2p-0.49.4.tar.gz #48

pts opened this issue Oct 3, 2018 · 2 comments

Comments

@pts
Copy link
Owner

pts commented Oct 3, 2018

Based on #47 reported by @dag-erling .

$ wget -qO sam2p-0.49.4.tar.gz https://github.com/pts/sam2p/releases/download/v0.49.4/sam2p-0.49.4.tar.gz
$ sha256sum sam2p-0.49.4.tar.gz
d23707b2405ca94e2a237cb81f62fb5916f5e4360cf9a705061479c8fa1dff5c  sam2p-0.49.4.tar.gz
$ tar tzf sam2p-0.49.4.tar.gz
(empty output)
$ tar xzf sam2p-0.49.4.tar.gz
(empty output)
$ tar tzvf sam2p-0.49.4.tar.gz | grep vcsam2p.ico 
-rw-r----- pts/eng        1078 2013-12-11 17:52 sam2p-0.49.4/vcsam2p.ico
hrw-r----- pts/eng           0 2013-12-11 17:52 sam2p-0.49.4/vcsam2p.ico link to sam2p-0.49.4/vcsam2p.ico
$ tar --version
tar (GNU tar) 1.30
(...)

The output line starting with hrw shouldn't appear.

Also tar -cf- should be used in make dist to make sure that tar writes to stdout (and not to $TAPE or some other compiled-in default).

@pts pts changed the title vcsam2p.ico symlink appears twice in vcsam2p.ico symlink appears twice in sam2p-0.49.4.tar.gz\ Oct 3, 2018
@pts pts changed the title vcsam2p.ico symlink appears twice in sam2p-0.49.4.tar.gz\ vcsam2p.ico symlink appears twice in sam2p-0.49.4.tar.gz Oct 3, 2018
@pts pts changed the title vcsam2p.ico symlink appears twice in sam2p-0.49.4.tar.gz vcsam2p.ico symlink appears in sam2p-0.49.4.tar.gz Oct 3, 2018
@dag-erling
Copy link
Contributor

It's not a symlink, it's a hard link. It seems that newer versions of GNU tar keep track of the device and inode number of every file they process and emit a hard link when they see a duplicate instead of including the same file twice. Attempting to link a file to itself when unpacking fails. #50 should fix this.

@pts pts changed the title vcsam2p.ico symlink appears in sam2p-0.49.4.tar.gz vcsam2p.ico hard link appears in sam2p-0.49.4.tar.gz Oct 3, 2018
@pts
Copy link
Owner Author

pts commented Oct 3, 2018

Thank you for the fix! Fixed in 4c0ab77.

@pts pts closed this as completed Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants