Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shift_register_gated #170

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Add shift_register_gated #170

merged 3 commits into from
Apr 14, 2023

Conversation

qian-gu
Copy link
Contributor

@qian-gu qian-gu commented Feb 22, 2023

A shift register with clock gating

Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @qian-gu for this PR. To avoid code fragmentation, could you adapt shift_reg such that it instantiates this module, tying valid_i to 1'b1 and leaving valid_o open? Furthermore, could you update the following files with this module:

  • Bender.yml
  • README.md
  • src_files.yml

Finally, please rebase to master (we updated the CI last night)

//
// Description: A Simple shift register with ICG for arbitrary depth and types.

`default_nettype none
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? If not, please remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This directive is added to ensure all internal variables are declared explicitly by designer. I will remove it to keep consistent with other modules.


endmodule

`default_nettype wire
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as L13

Comment on lines 39 to 42
logic [Depth-1 : 0] valid_d;
logic [Depth-1 : 0] valid_q;
dtype [Depth-1 : 0] data_d;
dtype [Depth-1 : 0] data_q;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapt this to our coding convention

Suggested change
logic [Depth-1 : 0] valid_d;
logic [Depth-1 : 0] valid_q;
dtype [Depth-1 : 0] data_d;
dtype [Depth-1 : 0] data_q;
logic [Depth-1:0] valid_d, valid_q;
dtype [Depth-1:0] data_d, data_q;

@niwis niwis linked an issue Feb 23, 2023 that may be closed by this pull request
Qian Gu added 2 commits February 23, 2023 23:57
@qian-gu
Copy link
Contributor Author

qian-gu commented Feb 27, 2023

update commits have been pushed, but the CI command

git remote add gitlab ***iis-git.ee.ethz.ch/github-mirror/common_cells
git push --force --mirror gitlab

gives an error message:

remote: HTTP Basic: Access denied. The provided password or token is incorrect or your account has 2FA enabled and you must use a personal access token instead of a password.

Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! The CI is failing since you don't have access to the required github secrets... we're working on a solution for future PRs.

@niwis niwis merged commit e22fce0 into pulp-platform:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A gated shift register module
2 participants