Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set bank count to nonzero in default parameter to avoid div by 0 #195

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Set bank count to nonzero in default parameter to avoid div by 0 #195

merged 2 commits into from
Aug 9, 2023

Conversation

uge
Copy link
Contributor

@uge uge commented Aug 8, 2023

Verilator crashes parsing mem_to_banks.sv because of a divide by zero if NumBanks is 0

niwis
niwis requested changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @uge. There were recent changes to mem_to_banks. Could you rebase your patch onto master and add the same change to mem_to_banks_detailed?

@uge uge requested a review from niwis August 9, 2023 12:29
niwis
niwis approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@niwis niwis merged commit 3b99511 into pulp-platform:master Aug 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niwis niwis niwis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uge @niwis