Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMS s3 endpoint extra_connection_attributes property is not set correctly when creating new endpoint #1491

Closed
samurex opened this issue May 17, 2021 · 3 comments
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@samurex
Copy link

samurex commented May 17, 2021

Hi, when I create new endpoint with engine_name='s3' and extra_connection_attributes="dataFormat=parquet;" the endpoint is created but ExtraConnectionAttributes is missing "dataFormat=parquet;". Interestingly this value is being saved correctly when endpoint is updated.

Expected behavior

After endpoint is created with extra_connection_attributes="dataFormat=parquet;" the value is saved to ExtraConnectionAttributes in aws

Current behavior

Currently ExtraConnectionAttributes is created from S3Settings (which doesn't contain DataFormat property)

Steps to reproduce

  1. create a task with engine_name='s3' and extra_connection_attributes="dataFormat=parquet;
  2. pulumi up
  3. go to the console or run cli to retrieve ExtraConnectionAttributes

Context (Environment)

We are not able to manage DMS with pulumi

Affected feature

pulumi dms

@samurex samurex added the kind/bug Some behavior is incorrect or out of spec label May 17, 2021
@lblackstone lblackstone added kind/bug Some behavior is incorrect or out of spec and removed kind/bug Some behavior is incorrect or out of spec labels May 18, 2021
@snikolakis
Copy link

Hello! Is there any update on that?

@lukehoban lukehoban added the awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). label Dec 24, 2022
@lukehoban
Copy link
Member

This appears to be due to hashicorp/terraform-provider-aws#19501, hashicorp/terraform-provider-aws#19667, hashicorp/terraform-provider-aws#23506. Once those are addressed upstream, the improvements will become available here as well.

@lukehoban lukehoban added the resolution/fixed This issue was fixed label Jun 24, 2023
@lukehoban
Copy link
Member

I believe this was fixed by hashicorp/terraform-provider-aws#19667. There isn't a complete repro here to validate against, but if anyone is still seeing issues here, add a repro and we can reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants