Function hash needs to consider environment

[joeduffy]

At the moment, we only consider the function text when we hash closures. See https://github.com/pulumi/pulumi-aws/blob/master/overlays/serverless/function.ts#L60. This means that functions with the same text but different closure environments may collide and share a hash, which will result in us serializing only one copy and binding all references to that one copy. This is clearly wrong.

Good catch from @CyrusNajmabadi.

[lukehoban]

Actually just hit this in practice for the first time today. Assigning to myself to fix in 0.7.

[joeduffy]

I know @lukehoban is out for a couple days, @CyrusNajmabadi, do you have time to take a whack at fixing this one?

[joeduffy]

@CyrusNajmabadi fixed this in pulumi/pulumi@556345c, closing out.

[CyrusNajmabadi]

Sorry, was going to close this when i got in. Will be more vigilant about doing that when i merge PRs in.