Fix flaky test TestAccKmsAliasTs #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is creating a KMS key alias with a static name. When multiple instances of this test are running in the same AWS account and region they'll race and occasionally fail because the alias already exists. This changes the key alias to use a name prefix to guarantee uniqueness.
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
/run-acceptance-tests |
|
Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/8690888034 |
corymhall
approved these changes
Apr 15, 2024
| @@ -23,7 +23,7 @@ const aliasAutoPrefixedWithAlias = new aws.kms.Alias("should-be-prefixed", {targ | |||
|
|
|||
| const aliasWithDedicatedName = new aws.kms.Alias("wont-be-autonamed", { | |||
| targetKeyId: key.keyId, | |||
| name: "alias/my-decicated-name" | |||
| namePrefix: "alias/my-decicated-name-" | |||
There was a problem hiding this comment.
It looks like this test might be intentionally testing setting a specific name. I can't think of a good reason for that though so this change looks good to me!
There was a problem hiding this comment.
I did think about generating a random name and using that for the name parameter, but I also couldn't think of a reason to keep it that way.
Alternatively we could test all three cases (auto-generated name, name, namePrefix)
t0yv0
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is creating a KMS key alias with a static name. When multiple
instances of this test are running in the same AWS account and region they'll race
and occasionally fail because the alias already exists.
This changes the key alias to use a name prefix to guarantee uniqueness.
This fixes: #3817