Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream v5.51.1 #3998

Merged
merged 4 commits into from
May 30, 2024
Merged

Upstream v5.51.1 #3998

merged 4 commits into from
May 30, 2024

Conversation

corymhall
Copy link
Contributor

closes #3987

Copy link

github-actions bot commented May 29, 2024

Does the PR have any schema changes?

Found 1 breaking change:

Functions

  • 🟡 "aws:route53/getZone:getZone": inputs: "resourceRecordSetCount" missing input "resourceRecordSetCount"

New resources:

  • lambda/runtimeManagementConfig.RuntimeManagementConfig
  • vpc/endpointPrivateDns.EndpointPrivateDns
  • vpc/endpointServicePrivateDnsVerification.EndpointServicePrivateDnsVerification

New functions:

  • chatbot/getSlackWorkspace.getSlackWorkspace

Maintainer note: consult the runbook for dealing with any breaking changes.

@@ -4724,6 +4725,8 @@ func ProviderFromMeta(metaInfo *tfbridge.MetadataInfo) *tfbridge.ProviderInfo {
"aws_batch_compute_environment": {Tok: awsDataSource(batchMod, "getComputeEnvironment")},
"aws_batch_job_queue": {Tok: awsDataSource(batchMod, "getJobQueue")},
"aws_batch_scheduling_policy": {Tok: awsDataSource(batchMod, "getSchedulingPolicy")},
// chatbot
"aws_chatbot_slack_workspace": {Tok: awsDataSource(chatbotMod, "getSlackWorkspace")},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the new resources to the separate plugin based resources, but it doesn't look like we have a separate place to put plugin based data sources.

Copy link
Contributor

@flostadler flostadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corymhall corymhall merged commit fafecbd into master May 30, 2024
27 checks passed
@corymhall corymhall deleted the upstream-v5.51.1 branch May 30, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-aws to v5.51.1
2 participants