Fix ListenerRule panic if no forward parameter is missing in defaultActions #4131
+159
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions In #4083 we removed two patches fixing panics for Listener and ListenerRule resources and instead enrolled the resources in PlanResourceChange. The ListenerRule (lb.ListenerRule and alb.ListenerRule) resources were missed to be enrolled in PlanResourceChange, which caused the original panic to surface again. This change enrolls the ListenerRule resources in PlanResourceChange and adds a regression test covering those resources.
flostadler
commented
Jun 28, 2024
| @@ -232628,4 +232628,4 @@ | |||
| "aws:workspaces/getWorkspace:getWorkspace": 0 | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
I'm not quite sure why this newline started disappearing. I tried adding it back and regenerating the file a couple of times but it kept happening
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
t0yv0
approved these changes
Jun 28, 2024
…sion or magic string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4083 we removed two patches fixing panics for
ListenerandListenerRuleresources and instead enrolled the resources inPlanResourceChange.The ListenerRule (
lb.ListenerRuleandalb.ListenerRule) resources were missed to be enrolled inPlanResourceChange, which caused the original panic to surface again.This change enrolls the ListenerRule resources in PlanResourceChange and adds a regression test covering those resources.
fixes #4128