-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Name" tag when creating resources #53
Comments
In principle I like this - but in practice I worry about automatically adding too much "policy" on top of the raw AWS and Terraform providers at the raw I'm tempted to believe our goal at this layer should be to give folks a raw projection of AWS that they can do what they want with. Per my comments in #2 (comment), I already wonder whether we may want to dial down the amount of layering we put on top of the raw Terraform providers here. More broadly, with both that issue and this one (and others) we should decide on what level of abstraction we want to provide in this library - and then consistently apply it. Note that we do provide users with the tools to add tags themselves - and we should be applying tags in all of our higher level frameworks. Specifically - pulumi/pulumi-cloud#117 is something we definitely should fix. |
Note that if we do this, it supersedes the work to manually do this that we added in pulumi/pulumi-cloud#333. |
I'm not sure this is a great idea in current form, though I do like the idea of attaching the "Pulumi name" in a tag in a similar manner to that described in #113. My reasoning is that in AWS, the |
When creating an instance such as
aws.ec2.Instance
, should use the first constructor argument to automatically name the resource using theName
property in thetags
collection.Should do this for all resources that are named, not just EC2.
The text was updated successfully, but these errors were encountered: