Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the ability to specify PolicyDocument in aws.iam.Policy #601

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Adding the ability to specify PolicyDocument in aws.iam.Policy #601

merged 1 commit into from
Jun 13, 2019

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jun 13, 2019

Fixes: #583

@stack72 stack72 added impact/usability Something that impacts users' ability to use the product easily and intuitively area/providers labels Jun 13, 2019
@stack72 stack72 requested a review from jen20 June 13, 2019 15:17
@stack72 stack72 self-assigned this Jun 13, 2019
jen20
jen20 approved these changes Jun 13, 2019
View reviewed changes
CHANGELOG.md
@@ -8,6 +8,7 @@ CHANGELOG
* Add constants for Route53 record types
* Subscription resources will now be parented by default by the resource they were created off of.
This has been implemented using 'aliases' so this will not have any effect on existing stacks.
* Adding the ability to specify `PolicyDocument` type as the `policy` field in `aws.iam.Policy`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Adding the ability to specify `PolicyDocument` type as the `policy` field in `aws.iam.Policy`
* Add the ability to pass a `PolicyDocument` in the `policy` field in `aws.iam.Policy`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will follow this up on the subsequent PR for the next enhancement

@stack72 stack72 merged commit dbf184c into master Jun 13, 2019
@pulumi-bot pulumi-bot deleted the stack72/gh-583 branch June 13, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen20 jen20 jen20 approved these changes

Assignees

@stack72 stack72

Labels
area/providers impact/usability Something that impacts users' ability to use the product easily and intuitively
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

policy property of aws.iam.Policy should accept PolicyDocument
2 participants
@stack72 @jen20