Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding constants for RDS InstanceTypes #613

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Adding constants for RDS InstanceTypes #613

merged 2 commits into from
Jun 20, 2019

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jun 19, 2019

Fixes: #592

@stack72 stack72 added kind/enhancement Improvements or new features area/providers labels Jun 19, 2019
@stack72 stack72 requested a review from jen20 June 19, 2019 13:51
@stack72 stack72 self-assigned this Jun 19, 2019
lukehoban
lukehoban approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sdk/nodejs/rds/instanceType.ts Outdated Show resolved Hide resolved
@stack72 stack72 merged commit 6a78b90 into master Jun 20, 2019
@pulumi-bot pulumi-bot deleted the stack72/gh-592 branch June 20, 2019 07:39
@snyk-bot snyk-bot mentioned this pull request May 25, 2021
Open
@elad-snyk elad-snyk mentioned this pull request Jun 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehoban lukehoban lukehoban approved these changes

@jen20 jen20 Awaiting requested review from jen20

Assignees

@stack72 stack72

Labels
area/providers kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add constants for RDS instance classes
3 participants
@stack72 @lukehoban @ellismg