Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppet-lint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.9
Choose a base ref
...
head repository: puppetlabs/puppet-lint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.10
Choose a head ref
  • 20 commits
  • 19 files changed
  • 2 contributors

Commits on Dec 27, 2011

  1. Configuration menu
    Copy the full SHA
    f07bc46 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2011

  1. Split each check out into a separate function

    This allows us to easily run selected checks only.
    This also splits the check logic up nicely so that it can be
    refactored without affecting the others.
    
    Common tasks such as tokenising the incoming data or finding the starting
    tokens of classes has been pulled out of the check logic as well to DRY
    things up.
    rodjek committed Dec 28, 2011
    Configuration menu
    Copy the full SHA
    e7442f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ec3567 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c691e8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7c4d139 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    55a40a9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ae5a633 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c54ccef View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2012

  1. Updated the --help output a bit.

    Put possible error levels on next line (80 column limit).
    Add separator between global options and --no-[name]-checks.
    vStone committed Jan 8, 2012
    Configuration menu
    Copy the full SHA
    7235b87 View commit details
    Browse the repository at this point in the history
  2. Introduced log format and some helper methods.

    bin/puppet-lint
    * Added the --log-format option.
      Added documentation to the --help output.
    
    lib/puppet-lint.rb
    * Check for 'string' % {hash} functionality and basic backport.
    
    * Added helper methods and the log-format configuration option to the main PuppetLint class.
      - log_format:     Gets the configured log-format.
                        Tries to mimic the old behavior if no
                        log-format has been set.
    
      - format_message: Format the message.
    vStone committed Jan 8, 2012
    Configuration menu
    Copy the full SHA
    3c5e852 View commit details
    Browse the repository at this point in the history
  3. Adjusted PuppetLint class for using problems.

    * change @path -> @FileInfo.
      Store more information on the file.
    
    * rewrite the report function.
      - can handle all problem types.
      - updates statistics on each kind (error,warning)
      - merge fileinfo in the message
      - add additional placeholder for uppercase kind (ERROR,WARNING)
      - filters on configured error_level
    
    * changed the run function.
      - heavily simplified since we offload error_level and statistics
        to the report function.
      - expects plugin return values to be a array of { problems }
    vStone committed Jan 8, 2012
    Configuration menu
    Copy the full SHA
    564159f View commit details
    Browse the repository at this point in the history
  4. Adjust PuppetLint::Plugin for use with problems

    * Remove warnings and errors attritube -> problems attribute.
    * Introduced @default_info
    * Removed warn and error and replaced by notify function.
      - notify function merged @default info with the message.
    * Adjusted run function
      - set the name of the check in @default_info
      - only return @problems in stead of errors and warnings in a hash.
    vStone committed Jan 8, 2012
    Configuration menu
    Copy the full SHA
    b882526 View commit details
    Browse the repository at this point in the history
  5. Added RSpec Matcher for making plugin testing easier with problems

    * Implemented filter_array_of_hashes (helper) function.
      - See source for an example.
    * Implemented have_problem check.
      - Checks if a problem exists in the array that matches the filter hash.
      - Add readable failure messages.
    * Implemented only_have_problem check.
      - Checks if the problem array only exists out of elements matching the filter hash.
      - Add readable failure messages.
    vStone committed Jan 8, 2012
    Configuration menu
    Copy the full SHA
    22224c1 View commit details
    Browse the repository at this point in the history
  6. Updated all spec tests to use the new problem array.

    * Checks use its(:problems) now.
    
    NOTE:
     In some cases, I was unsure wether to use
    
      its(:problems) { should only_have_problem :kind => :warning, :message => "..." }
     or
      its(:problems) {
        should have_problem :kind => :warning, :message => ''
        should_not have_problem :kind => :error
      }
    
      The first one fails if there are any other warnings and/or errors returned.
      The second one only fails if there are any errors but allows other warnings.
    vStone committed Jan 8, 2012
    Configuration menu
    Copy the full SHA
    07d18fb View commit details
    Browse the repository at this point in the history
  7. Updated all plugins to use notify in stead of error/warn.

    * A small implication is that I removed the linenumbers from within
      the message and moved it to :linenumber. There is now a warning
      that an error occured on a line, but the line number is added
      separatly.
      In some cases, with default (backwards compatible)  formatting,
      this results in "line has more than 80 characters on line 4".
      (Original was: "line 4 has more than 80 characters")
    vStone committed Jan 8, 2012
    Configuration menu
    Copy the full SHA
    db18679 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f29bab5 View commit details
    Browse the repository at this point in the history
  9. Added rdoc rake task.

    vStone committed Jan 8, 2012
    Configuration menu
    Copy the full SHA
    aa3c101 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2012

  1. Configuration menu
    Copy the full SHA
    44f1278 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2012

  1. Configuration menu
    Copy the full SHA
    adc01bb View commit details
    Browse the repository at this point in the history
  2. Bump version to 0.1.10

    rodjek committed Jan 11, 2012
    Configuration menu
    Copy the full SHA
    2279e93 View commit details
    Browse the repository at this point in the history
Loading