-
Notifications
You must be signed in to change notification settings - Fork 13
Comparing changes
Open a pull request
base repository: puppetlabs/puppet-lint
base: 0.1.9
head repository: puppetlabs/puppet-lint
compare: 0.1.10
- 20 commits
- 19 files changed
- 2 contributors
Commits on Dec 27, 2011
-
Configuration menu - View commit details
-
Copy full SHA for f07bc46 - Browse repository at this point
Copy the full SHA f07bc46View commit details
Commits on Dec 28, 2011
-
Split each check out into a separate function
This allows us to easily run selected checks only. This also splits the check logic up nicely so that it can be refactored without affecting the others. Common tasks such as tokenising the incoming data or finding the starting tokens of classes has been pulled out of the check logic as well to DRY things up.
Configuration menu - View commit details
-
Copy full SHA for e7442f7 - Browse repository at this point
Copy the full SHA e7442f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ec3567 - Browse repository at this point
Copy the full SHA 7ec3567View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c691e8 - Browse repository at this point
Copy the full SHA 4c691e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c4d139 - Browse repository at this point
Copy the full SHA 7c4d139View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55a40a9 - Browse repository at this point
Copy the full SHA 55a40a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae5a633 - Browse repository at this point
Copy the full SHA ae5a633View commit details -
Configuration menu - View commit details
-
Copy full SHA for c54ccef - Browse repository at this point
Copy the full SHA c54ccefView commit details
Commits on Jan 8, 2012
-
Updated the --help output a bit.
Put possible error levels on next line (80 column limit). Add separator between global options and --no-[name]-checks.
Configuration menu - View commit details
-
Copy full SHA for 7235b87 - Browse repository at this point
Copy the full SHA 7235b87View commit details -
Introduced log format and some helper methods.
bin/puppet-lint * Added the --log-format option. Added documentation to the --help output. lib/puppet-lint.rb * Check for 'string' % {hash} functionality and basic backport. * Added helper methods and the log-format configuration option to the main PuppetLint class. - log_format: Gets the configured log-format. Tries to mimic the old behavior if no log-format has been set. - format_message: Format the message.
Configuration menu - View commit details
-
Copy full SHA for 3c5e852 - Browse repository at this point
Copy the full SHA 3c5e852View commit details -
Adjusted PuppetLint class for using problems.
* change @path -> @FileInfo. Store more information on the file. * rewrite the report function. - can handle all problem types. - updates statistics on each kind (error,warning) - merge fileinfo in the message - add additional placeholder for uppercase kind (ERROR,WARNING) - filters on configured error_level * changed the run function. - heavily simplified since we offload error_level and statistics to the report function. - expects plugin return values to be a array of { problems }
Configuration menu - View commit details
-
Copy full SHA for 564159f - Browse repository at this point
Copy the full SHA 564159fView commit details -
Adjust PuppetLint::Plugin for use with problems
* Remove warnings and errors attritube -> problems attribute. * Introduced @default_info * Removed warn and error and replaced by notify function. - notify function merged @default info with the message. * Adjusted run function - set the name of the check in @default_info - only return @problems in stead of errors and warnings in a hash.
Configuration menu - View commit details
-
Copy full SHA for b882526 - Browse repository at this point
Copy the full SHA b882526View commit details -
Added RSpec Matcher for making plugin testing easier with problems
* Implemented filter_array_of_hashes (helper) function. - See source for an example. * Implemented have_problem check. - Checks if a problem exists in the array that matches the filter hash. - Add readable failure messages. * Implemented only_have_problem check. - Checks if the problem array only exists out of elements matching the filter hash. - Add readable failure messages.
Configuration menu - View commit details
-
Copy full SHA for 22224c1 - Browse repository at this point
Copy the full SHA 22224c1View commit details -
Updated all spec tests to use the new problem array.
* Checks use its(:problems) now. NOTE: In some cases, I was unsure wether to use its(:problems) { should only_have_problem :kind => :warning, :message => "..." } or its(:problems) { should have_problem :kind => :warning, :message => '' should_not have_problem :kind => :error } The first one fails if there are any other warnings and/or errors returned. The second one only fails if there are any errors but allows other warnings.
Configuration menu - View commit details
-
Copy full SHA for 07d18fb - Browse repository at this point
Copy the full SHA 07d18fbView commit details -
Updated all plugins to use notify in stead of error/warn.
* A small implication is that I removed the linenumbers from within the message and moved it to :linenumber. There is now a warning that an error occured on a line, but the line number is added separatly. In some cases, with default (backwards compatible) formatting, this results in "line has more than 80 characters on line 4". (Original was: "line 4 has more than 80 characters")
Configuration menu - View commit details
-
Copy full SHA for db18679 - Browse repository at this point
Copy the full SHA db18679View commit details -
Configuration menu - View commit details
-
Copy full SHA for f29bab5 - Browse repository at this point
Copy the full SHA f29bab5View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa3c101 - Browse repository at this point
Copy the full SHA aa3c101View commit details
Commits on Jan 9, 2012
-
Configuration menu - View commit details
-
Copy full SHA for 44f1278 - Browse repository at this point
Copy the full SHA 44f1278View commit details
Commits on Jan 11, 2012
-
Configuration menu - View commit details
-
Copy full SHA for adc01bb - Browse repository at this point
Copy the full SHA adc01bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2279e93 - Browse repository at this point
Copy the full SHA 2279e93View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.1.9...0.1.10