Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3) [Bug] Project Entry Dialog: ESC not only dismisses dropdown (e.g. "Von" Month), but entire dialog #392

Closed
hellerbarde opened this issue Oct 14, 2020 · 6 comments
Assignees
Labels
bug Something isn't working plan needs to be planned

Comments

@hellerbarde
Copy link

hellerbarde commented Oct 14, 2020

Ich habe grad eine Viertelstunde Text für ein Projekt eingetippt und wollte beim Von-Bis-Eingeben das Monats-Dropdown dismissen mit ESC, und dann hat es den gesamten Projekt erfassen Dialog ohne Warnung weggemacht und die Arbeit war weg.

Ich würde mich über einen entsprechenden "Cancel - Are you sure?"-Dialog freuen.

EDIT: I changed the title to Bug because in most UI Framework I am aware of, ESC in a dropdown only dismisses the dropdown, and does not interact with the containing Element/Window.

@hellerbarde hellerbarde changed the title [Feature] Project Entry Dialog: ESC not only dismisses dropdown (e.g. "Von" Month), but entire dialog [Bug] Project Entry Dialog: ESC not only dismisses dropdown (e.g. "Von" Month), but entire dialog Oct 14, 2020
@Robin481
Copy link
Member

Merci für dein Feedback und sorry für die Umstände.
Wir entwickeln ab Januar wieder am PuzzleSkills weiter, ich nehme dein Feedback für dann gerne in die Planung auf.

@Robin481 Robin481 added bug Something isn't working plan needs to be planned labels Oct 14, 2020
@Robin481 Robin481 self-assigned this Oct 14, 2020
@hellerbarde
Copy link
Author

Cool Danke :)

@Robin481
Copy link
Member

TODO:

  • Add an overlay that asks to confirm if you really want to stop editing a field if there are unsave changes (doesn't matter if this is coming from an ESC press or pressing the cancel button)
  • Allow the date dropdowns to be closed with ESC without affecting/closing the whole form
  • Write tests for the above feature

@njaeggi njaeggi assigned njaeggi and unassigned Robin481 Feb 16, 2023
@njaeggi
Copy link
Contributor

njaeggi commented Feb 20, 2023

I have added a confirmation Modal when clicking the cancel button in form. I still have to look at the problem with the esc key and fix it. Styling of the new modal should also be done too and tests need to be implemented

@Robin481 Robin481 changed the title [Bug] Project Entry Dialog: ESC not only dismisses dropdown (e.g. "Von" Month), but entire dialog (5) [Bug] Project Entry Dialog: ESC not only dismisses dropdown (e.g. "Von" Month), but entire dialog Feb 20, 2023
@njaeggi
Copy link
Contributor

njaeggi commented Feb 27, 2023

This feature is basically implemented, but is blocked by another issues #348, # 349, #350. After those issues are implemented, this issue needs to be tested.

@Robin481 Robin481 changed the title (5) [Bug] Project Entry Dialog: ESC not only dismisses dropdown (e.g. "Von" Month), but entire dialog (3) [Bug] Project Entry Dialog: ESC not only dismisses dropdown (e.g. "Von" Month), but entire dialog Feb 27, 2023
@Robin481
Copy link
Member

Robin481 commented Jun 2, 2023

Fixed with the new release, thanks for the issue!

@Robin481 Robin481 closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plan needs to be planned
Projects
None yet
Development

No branches or pull requests

3 participants