Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1 - The base64 screenshots are huge - maybe consider doing the same approach as icons (or at least an option) #4546

Open
Tracked by #3381
khmyznikov opened this issue Nov 27, 2023 · 0 comments
Open
Tracked by #3381

P1 - The base64 screenshots are huge - maybe consider doing the same approach as icons (or at least an option) #4546

khmyznikov opened this issue Nov 27, 2023 · 0 comments
Assignees
@khmyznikov

Comments

@khmyznikov
Copy link
Contributor

khmyznikov commented Nov 27, 2023 •
edited

Completely remove base64 approach as anti-pattern.
Switch to ZIP with generated images and manifest file.
Manifest file should have pre-populated screenshots object with src of generated images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khmyznikov khmyznikov

Labels
None yet
Projects
PWABuilder
Status: Todo 📃
Milestone
No milestone
Development

No branches or pull requests
1 participant
@khmyznikov