Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BaseModel.rebuild() and BaseModel.build() #444

Closed
BradyPlanden opened this issue Aug 7, 2024 · 0 comments · Fixed by #451
Closed

Refactor BaseModel.rebuild() and BaseModel.build() #444

BradyPlanden opened this issue Aug 7, 2024 · 0 comments · Fixed by #451
Assignees
@NicolaCourtier
Labels
enhancement New feature or request

Comments

@BradyPlanden
Copy link
Member

Feature description

Combine the methods with a clear docstring on when a new build is trigger compared to returning the currently build model.

Motivation

Simplifies the codebase and reduces maintance. Fundementally these methods can be combined without issue.

Possible implementation

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicolaCourtier NicolaCourtier

Labels
enhancement New feature or request
Projects
v24.9
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge model build and rebuild pybop-team/PyBOP
2 participants
@NicolaCourtier @BradyPlanden