Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Multivariate Hypergeometric? #139

Open
kyleabeauchamp opened this issue Oct 12, 2016 · 0 comments
Open

Bug in Multivariate Hypergeometric? #139

kyleabeauchamp opened this issue Oct 12, 2016 · 0 comments

Comments

@kyleabeauchamp
Copy link
Contributor

AFAIK, the multivariate hypergeometric should depend on the number of draws performed (n, in the wikipedia nomenclature) and the number of each marble type (K_i, in the wikipedia nomenclature).

However, the pymc RV object only has m as a parent (see docstring below). Interestingly, the expected value and moment calculations (https://github.com/pymc-devs/pymc/blob/0c9958838014e2b5693c56ebd4fc32a96632f189/pymc/distributions.py#L1845) seem OK, it's just the logP that's wrong (https://github.com/pymc-devs/pymc/blob/0c9958838014e2b5693c56ebd4fc32a96632f189/pymc/distributions.py#L1882).

pm.MultivariateHypergeometric(self, *args, **kwds)
Docstring:     
M = MultivariateHypergeometric(name, m, value=None, observed=False, trace=True, rseed=True, doc=None, verbose=-1, debug=False)

Stochastic variable with MultivariateHypergeometric distribution.
Parents are: m.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant