Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is setup.py? #46

Closed
b-long opened this issue Sep 28, 2017 · 3 comments
Closed

What is setup.py? #46

b-long opened this issue Sep 28, 2017 · 3 comments

Comments

@b-long
Copy link

b-long commented Sep 28, 2017

Hi there,

First off, thanks for creating hatch! For a long time, I've been confused by idempotent Python. I work in many languages, and so the particulars of a given language can sometimes escape me.

I assume your goal is to make Python development simpler. As such, it'd be fantastic if you could place a bit of a description (in the form of comments) at the top of setup.py. I say this, since it seems like a few hundred StackOverflow users have also been mystified by this convention [0].

Thanks again!

0 : https://stackoverflow.com/questions/1471994/what-is-setup-py

@ofek
Copy link
Sponsor Collaborator

ofek commented Sep 28, 2017

I'm glad Hatch is helping you!

As pyproject.toml will replace setup.py, I think this is a bit out of scope. If you want some more info about it anyway check out https://github.com/kennethreitz/setup.py

Thanks!

@ofek ofek closed this as completed Sep 28, 2017
@b-long
Copy link
Author

b-long commented Sep 28, 2017

Thanks @ofek , thats incredibly helpful 👍 I was unaware of pyproject.toml and kennethreitz's helpful repository.

I won't be a pest, but, just offering one more idea -- you could add exactly the comment you've made here to the setup.py file 😄

@ofek
Copy link
Sponsor Collaborator

ofek commented Sep 28, 2017

No, because I wouldn't want to take away an easy commit from you :)

Submit a PR adding a comment here https://github.com/ofek/hatch/blob/master/hatch/files/setup.py#L5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants