Rename pip._internal.distributions.{source -> sdist}

[pradyunsg]

Certain environments seem to be leaving behind empty folders in this
directory -- There was an older pip release that included a source/
folder here which isn't getting deleted for some reason (or that's getting added
somehow). I have not figured out the root cause why this happens yet. This is
resulting in ImportErrors since Python imports have a higher precedence for
packages compared to modules.

This PR changes the name we're trying to import from, which should
help prevent this mode of failure.

Should help with #7217.

[pradyunsg]

Ah great. that our own CI pipelines are affected by it. This is gonna be one fun release to make.

[sbidoul]

@pradyunsg are there downsides to pulling 20.0 of PyPI until 20.0.1 is ready?

[pradyunsg]

Yea, that'll cause different kinds of breakages. We really need the ability to yank releases on PyPI -- pypi/warehouse#5838 -- for things like this.

For now, I'm just admin-merging this and making the release.

[graingert]

perhaps the "pip._internal" package name should be renamed each release? eg "pip._internal_020_000_000" and "pip._internal_019_003_001"

[graingert]

Pleae don't yank releases, you should tag 19.3.1 as 20.1 as revert if needed

You should probably discuss that here: pypi/warehouse#5838

[HenrikOssipoff]

@pradyunsg I want to thank you for the very quick handling of this issue. Much appreciated 🥇

[honnix]

fwiw it must be something where code is cached, because after installing 20.0.1, I have

ll /Users/honnix/.virtualenvs/test-pip/lib/python3.7/site-packages/pip/_internal/distributions/
total 48
-rw-r--r--  1 honnix  staff   959B Jan 21 14:10 __init__.py
drwxr-xr-x  8 honnix  staff   256B Jan 21 14:10 __pycache__
-rw-r--r--  1 honnix  staff   1.4K Jan 21 14:10 base.py
-rw-r--r--  1 honnix  staff   760B Jan 21 14:10 installed.py
-rw-r--r--  1 honnix  staff   4.0K Jan 21 14:10 sdist.py      <-----------
drwxr-xr-x  5 honnix  staff   160B Jan 21 14:10 source        <-----------
-rw-r--r--  1 honnix  staff   4.0K Jan 21 14:10 source.py     <-----------
-rw-r--r--  1 honnix  staff   1.3K Jan 21 14:10 wheel.py

[RDIL]

Thanks for the fix 😃

[arlind87]

Thnx for the fix. Much appreciated

[pradyunsg]

fwiw it must be something where code is cached, because after installing 20.0.1, I have

Yep -- circa pypa/wheel#147. We'll be fixing our release process automation to prevent this kind of failure from ever happening again: #7624.

[mehuled]

Thanks for the fix.

[fusionking]

Thank you for the fix