Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecation warnings (shape.py, locators.py) #468

Merged
merged 9 commits into from
Jun 13, 2022

Conversation

jGaboardi
Copy link
Member

This PR follows up from the 2022-05-11 steering council meeting and updates the current warning in locators.py from a DeprecationWarning, which is not triggered, to FutureWarning. Warnings are also added to all classes in shape.py that inherit the Geometry class.

xref #292, pysal/spaghetti#649

@jGaboardi jGaboardi self-assigned this May 15, 2022
@jGaboardi
Copy link
Member Author

Failures appear to be due to current issues with micromamba. Will attempt rerun later.

@jGaboardi jGaboardi added the cg label May 15, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #468 (788dd0f) into master (1766b39) will increase coverage by 0.0%.
The diff coverage is 75.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #468   +/-   ##
======================================
  Coverage    79.4%   79.4%           
======================================
  Files         122     122           
  Lines       12957   12968   +11     
======================================
+ Hits        10282   10297   +15     
+ Misses       2675    2671    -4     
Impacted Files Coverage Δ
libpysal/cg/locators.py 60.3% <40.0%> (ø)
libpysal/cg/segmentLocator.py 50.0% <50.0%> (ø)
libpysal/cg/shapes.py 89.7% <100.0%> (+0.2%) ⬆️
libpysal/examples/base.py 64.4% <0.0%> (-3.4%) ⬇️
libpysal/_version.py 40.7% <0.0%> (+2.7%) ⬆️

@sjsrey
Copy link
Member

sjsrey commented Jun 12, 2022

@jGaboardi this looks good - thanks for the updating. Is this ready to go?

@jGaboardi
Copy link
Member Author

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants