Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic polling of remotes #504

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Remove automatic polling of remotes #504

merged 1 commit into from
Jan 6, 2023

Conversation

sjsrey
Copy link
Member

@sjsrey sjsrey commented Jan 4, 2023

This addresses #499 by no longer polling the remotes on init.

Remotes would be curated prior to each release instead.

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #504 (2c3b43d) into master (390c5c4) will decrease coverage by 0.5%.
The diff coverage is 50.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #504     +/-   ##
========================================
- Coverage    79.2%   78.7%   -0.5%     
========================================
  Files         121     122      +1     
  Lines       13016   13114     +98     
========================================
+ Hits        10306   10322     +16     
- Misses       2710    2792     +82     
Impacted Files Coverage Δ
libpysal/examples/base.py 58.9% <0.0%> (-1.1%) ⬇️
libpysal/examples/remotes.py 74.4% <85.7%> (-21.4%) ⬇️
libpysal/common.py 63.5% <0.0%> (-26.9%) ⬇️
libpysal/weights/tests/test_nx.py 92.3% <0.0%> (-7.7%) ⬇️
libpysal/cg/tests/test_voronoi.py 82.8% <0.0%> (-6.9%) ⬇️
libpysal/io/iohandlers/db.py 41.9% <0.0%> (-6.5%) ⬇️
libpysal/weights/raster.py 57.2% <0.0%> (-3.8%) ⬇️
libpysal/cg/ops/_shapely.py 46.7% <0.0%> (-3.3%) ⬇️
libpysal/cg/ops/tests/test_tabular.py 96.8% <0.0%> (-3.2%) ⬇️
... and 15 more

Copy link
Member

@knaaptime knaaptime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@iwishiwasaneagle
Copy link

Looks good to me. Cheers for creating this fix @sjsrey!

@sjsrey sjsrey merged commit 4b99c09 into pysal:master Jan 6, 2023
@martinfleis
Copy link
Member

One more thing on this. GeoPandas is deprecating datasets module (geopandas/geopandas#2751) and we want to offer a convenient way of replacing this with something like https://github.com/martinfleis/xyzdata. I've used the data we have in here right now as a test and thought that the package may eventually live under pysal org and replace libpysal.examples. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants